components/bookmarks/common/android/java/src/org/chromium/components/bookmarks/BookmarkId.java - Issue 1002883002: Fix up if statement curly braces issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/common/android/java/src/org/chromium/components/bookmarks/BookmarkId.java

Issue 1002883002: Fix up if statement curly braces issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/notifications/MockNotificationManagerProxy.java ('k') | components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/bookmarks/common/android/java/src/org/chromium/components/bookmarks/BookmarkId.java

diff --git a/components/bookmarks/common/android/java/src/org/chromium/components/bookmarks/BookmarkId.java b/components/bookmarks/common/android/java/src/org/chromium/components/bookmarks/BookmarkId.java

index e7e26fe50494ebb491f4886fcd830b5b87847a6b..683eaba0729a4eddb5ad22049c21397db8f7bdd2 100644

--- a/components/bookmarks/common/android/java/src/org/chromium/components/bookmarks/BookmarkId.java

+++ b/components/bookmarks/common/android/java/src/org/chromium/components/bookmarks/BookmarkId.java

@@ -56,8 +56,7 @@ public class BookmarkId {

public static BookmarkId getBookmarkIdFromString(String s) {

long id = ROOT_FOLDER_ID;

int type = BookmarkType.NORMAL;

- if (TextUtils.isEmpty(s))

- return new BookmarkId(id, type);

+ if (TextUtils.isEmpty(s)) return new BookmarkId(id, type);

char folderTypeChar = s.charAt(0);

if (isValidBookmarkTypeFromChar(folderTypeChar)) {

type = getBookmarkTypeFromChar(folderTypeChar);

@@ -114,8 +113,7 @@ public class BookmarkId {

@Override

public boolean equals(Object o) {

- if (!(o instanceof BookmarkId))

- return false;

+ if (!(o instanceof BookmarkId)) return false;

BookmarkId item = (BookmarkId) o;

return (item.mId == mId && item.mType == mType);

}