Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Unified Diff: content/public/test/test_renderer_host.h

Issue 1002803002: Classify navigations without page id in parallel to the existing classifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: relax the dcheck Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/test/render_view_test.cc ('k') | content/public/test/test_renderer_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/test_renderer_host.h
diff --git a/content/public/test/test_renderer_host.h b/content/public/test/test_renderer_host.h
index e4eb93d4fd471a7919d16bdadf1edfcf9d097473..001a48e00b1144ce2410b94edca315430a358c0d 100644
--- a/content/public/test/test_renderer_host.h
+++ b/content/public/test/test_renderer_host.h
@@ -71,17 +71,27 @@ class RenderFrameHostTester {
virtual RenderFrameHost* AppendChild(const std::string& frame_name) = 0;
// Calls OnDidCommitProvisionalLoad on the RenderFrameHost with the given
- // information. Sets the rest of the parameters in the message to the
- // "typical" values. This is a helper function for simulating the most common
- // types of loads.
- virtual void SendNavigate(int page_id, const GURL& url) = 0;
- virtual void SendFailedNavigate(int page_id, const GURL& url) = 0;
-
- // Calls OnDidCommitProvisionalLoad on the RenderFrameHost with the given
- // information, including a custom PageTransition. Sets the rest of the
- // parameters in the message to the "typical" values. This is a helper
- // function for simulating the most common types of loads.
+ // information with various sets of parameters. These are helper functions for
+ // simulating the most common types of loads.
+ //
+ // Guidance for calling these:
+ // - nav_entry_id should be 0 if simulating a renderer-initiated navigation;
+ // if simulating a browser-initiated one, pass the GetUniqueID() value of
+ // the NavigationController's PendingEntry.
+ // - did_create_new_entry should be true if simulating a navigation that
+ // created a new navigation entry; false for history navigations, reloads,
+ // and other navigations that don't affect the history list.
+ virtual void SendNavigate(int page_id,
+ int nav_entry_id,
+ bool did_create_new_entry,
+ const GURL& url) = 0;
+ virtual void SendFailedNavigate(int page_id,
+ int nav_entry_id,
+ bool did_create_new_entry,
+ const GURL& url) = 0;
virtual void SendNavigateWithTransition(int page_id,
+ int nav_entry_id,
+ bool did_create_new_entry,
const GURL& url,
ui::PageTransition transition) = 0;
« no previous file with comments | « content/public/test/render_view_test.cc ('k') | content/public/test/test_renderer_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698