content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc - Issue 1002803002: Classify navigations without page id in parallel to the existing classifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc

Issue 1002803002: Classify navigations without page id in parallel to the existing classifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: relax the dcheck Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_view_host_unittest.cc ('k') | content/browser/web_contents/web_contents_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc

diff --git a/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc b/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc

index 8b6c78424b9ed7747849f6857cb2b655712a38b9..9844e6cff5398d0f72f6abfb0842ac00f8a50b79 100644

--- a/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc

+++ b/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc

@@ -253,8 +253,9 @@ TEST_F(OverscrollNavigationOverlayTest, CancelAfterSuccessfulNavigation) {

EXPECT_EQ(GetOverlay()->direction_, OverscrollNavigationOverlay::NONE);

EXPECT_TRUE(contents()->CrossProcessNavigationPending());

+ NavigationEntry* pending = contents()->GetController().GetPendingEntry();

main_test_rfh()->SendNavigate(

- 1, contents()->GetController().GetPendingEntry()->GetURL());

+ 0, pending->GetUniqueID(), false, pending->GetURL());

EXPECT_EQ(contents()->GetURL(), third());

}

@@ -268,8 +269,9 @@ TEST_F(OverscrollNavigationOverlayTest, Navigation_PaintUpdate) {

// for the previous page, so we should still be observing.

EXPECT_TRUE(GetOverlay()->web_contents());

+ NavigationEntry* pending = contents()->GetController().GetPendingEntry();

main_test_rfh()->SendNavigate(

- 1, contents()->GetController().GetPendingEntry()->GetURL());

+ 0, pending->GetUniqueID(), false, pending->GetURL());

ReceivePaintUpdate();

// Navigation was committed and the paint update was received - we should no

@@ -291,8 +293,9 @@ TEST_F(OverscrollNavigationOverlayTest, Navigation_LoadingUpdate) {

contents()->TestSetIsLoading(true);

contents()->TestSetIsLoading(false);

EXPECT_FALSE(GetOverlay()->web_contents());

+ NavigationEntry* pending = contents()->GetController().GetPendingEntry();

main_test_rfh()->SendNavigate(

- 1, contents()->GetController().GetPendingEntry()->GetURL());

+ 0, pending->GetUniqueID(), false, pending->GetURL());

EXPECT_EQ(contents()->GetURL(), third());

}