content/browser/frame_host/navigator_impl.cc - Issue 1002803002: Classify navigations without page id in parallel to the existing classifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 1002803002: Classify navigations without page id in parallel to the existing classifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: relax the dcheck Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/navigator_impl.cc

diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc

index 4ec6612a1c81150762435ce769909704d31261e0..52ed3c0d4a237ff3e6c41c63b2d6a3845a831a68 100644

--- a/content/browser/frame_host/navigator_impl.cc

+++ b/content/browser/frame_host/navigator_impl.cc

@@ -328,7 +328,9 @@ bool NavigatorImpl::NavigateToEntry(

entry.ConstructCommonNavigationParams(navigation_type),

entry.ConstructStartNavigationParams(),

entry.ConstructRequestNavigationParams(

- navigation_start, controller_->GetIndexOfEntry(&entry),

+ navigation_start,

+ controller_->GetPendingEntryIndex() == -1,

+ controller_->GetIndexOfEntry(&entry),

controller_->GetLastCommittedEntryIndex(),

controller_->GetEntryCount()));

} else {

« no previous file with comments | « content/browser/frame_host/navigation_request.cc ('k') | content/browser/frame_host/navigator_impl_unittest.cc » ('j') | no next file with comments »