content/browser/frame_host/navigation_entry_impl.cc - Issue 1002803002: Classify navigations without page id in parallel to the existing classifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_entry_impl.cc

Issue 1002803002: Classify navigations without page id in parallel to the existing classifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: intended Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_controller_impl_browsertest.cc ('K') | « content/browser/frame_host/navigation_entry_impl.h ('k') | content/browser/frame_host/navigation_request.cc » ('j') | content/common/frame_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_entry_impl.cc

diff --git a/content/browser/frame_host/navigation_entry_impl.cc b/content/browser/frame_host/navigation_entry_impl.cc

index 12cafa65da2a8158d7222431ba9735a742405ee5..b77497fa463993828c826024d2f012f8abc45f2e 100644

--- a/content/browser/frame_host/navigation_entry_impl.cc

+++ b/content/browser/frame_host/navigation_entry_impl.cc

@@ -421,6 +421,7 @@ StartNavigationParams NavigationEntryImpl::ConstructStartNavigationParams()

RequestNavigationParams NavigationEntryImpl::ConstructRequestNavigationParams(

base::TimeTicks navigation_start,

+ bool intended_as_new_entry,

int pending_history_list_offset,

int current_history_list_offset,

int current_history_list_length) const {

@@ -445,8 +446,8 @@ RequestNavigationParams NavigationEntryImpl::ConstructRequestNavigationParams(

return RequestNavigationParams(

GetIsOverridingUserAgent(), navigation_start, redirects,

GetCanLoadLocalResources(), GetFrameToNavigate(), base::Time::Now(),

- GetPageState(), GetPageID(), pending_offset_to_send,

- current_offset_to_send, current_length_to_send,

+ GetPageState(), GetPageID(), GetUniqueID(), intended_as_new_entry,

+ pending_offset_to_send, current_offset_to_send, current_length_to_send,

should_clear_history_list());

}