content/public/test/render_view_test.cc - Issue 1002803002: Classify navigations without page id in parallel to the existing classifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/render_view_test.cc

Issue 1002803002: Classify navigations without page id in parallel to the existing classifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase again Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/common/frame_navigate_params.h ('K') | « content/public/common/frame_navigate_params.cc ('k') | content/public/test/test_renderer_host.h » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/render_view_test.cc

diff --git a/content/public/test/render_view_test.cc b/content/public/test/render_view_test.cc

index ca67587df8b334707b223f0019aed624b7ebd983..70b50eccf00df3cd02485a3edeb9783b89578626 100644

--- a/content/public/test/render_view_test.cc

+++ b/content/public/test/render_view_test.cc

@@ -452,6 +452,7 @@ void RenderViewTest::GoToOffset(int offset, const PageState& state) {

RequestNavigationParams request_params;

request_params.page_state = state;

request_params.page_id = impl->page_id_ + offset;

+ request_params.nav_entry_id = pending_offset + 1;

request_params.pending_history_list_offset = pending_offset;

request_params.current_history_list_offset = impl->history_list_offset_;

request_params.current_history_list_length = history_list_length;