content/common/navigation_params.cc - Issue 1002803002: Classify navigations without page id in parallel to the existing classifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/navigation_params.cc

Issue 1002803002: Classify navigations without page id in parallel to the existing classifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase again Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/navigation_params.h ('K') | « content/common/navigation_params.h ('k') | content/public/common/frame_navigate_params.h » ('j') | content/public/common/frame_navigate_params.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/navigation_params.cc

diff --git a/content/common/navigation_params.cc b/content/common/navigation_params.cc

index 0e8df3c97cee673054e3bf6b100505270cdf2aaf..191f9c1b8c2484ea9bfc6b2f314ffa4e7ceb02d0 100644

--- a/content/common/navigation_params.cc

+++ b/content/common/navigation_params.cc

@@ -84,6 +84,7 @@ RequestNavigationParams::RequestNavigationParams()

can_load_local_resources(false),

request_time(base::Time::Now()),

page_id(-1),

+ nav_entry_id(0),

pending_history_list_offset(-1),

current_history_list_offset(-1),

current_history_list_length(0),

@@ -99,6 +100,7 @@ RequestNavigationParams::RequestNavigationParams(

base::Time request_time,

const PageState& page_state,

int32 page_id,

+ int nav_entry_id,

int pending_history_list_offset,

int current_history_list_offset,

int current_history_list_length,

@@ -111,6 +113,7 @@ RequestNavigationParams::RequestNavigationParams(

request_time(request_time),

page_state(page_state),

page_id(page_id),

+ nav_entry_id(nav_entry_id),

pending_history_list_offset(pending_history_list_offset),

current_history_list_offset(current_history_list_offset),

current_history_list_length(current_history_list_length),