content/public/test/render_view_test.cc - Issue 1002803002: Classify navigations without page id in parallel to the existing classifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/render_view_test.cc

Issue 1002803002: Classify navigations without page id in parallel to the existing classifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: better crash url Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/renderer/navigation_state.h ('K') | « content/public/renderer/navigation_state.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/render_view_test.cc

diff --git a/content/public/test/render_view_test.cc b/content/public/test/render_view_test.cc

index f0e0f8c011d0b1f33a6ab6abae4c8a770c130afc..796c4424a034213e5b9f702b08c40d143f14d6a7 100644

--- a/content/public/test/render_view_test.cc

+++ b/content/public/test/render_view_test.cc

@@ -448,7 +448,7 @@ void RenderViewTest::GoToOffset(int offset, const PageState& state) {

FrameMsg_Navigate_Type::NORMAL, true, base::TimeTicks(),

FrameMsg_UILoadMetricsReportType::NO_REPORT, GURL(), GURL());

HistoryNavigationParams history_params(

- state, impl->page_id_ + offset, pending_offset,

+ state, impl->page_id_ + offset, 0, pending_offset,

impl->history_list_offset_, history_list_length, false);

impl->GetMainRenderFrame()->OnNavigate(common_params, StartNavigationParams(),