Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1607)

Unified Diff: content/common/navigation_params.h

Issue 1002803002: Classify navigations without page id in parallel to the existing classifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: better crash url Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/navigation_params.h
diff --git a/content/common/navigation_params.h b/content/common/navigation_params.h
index 9b3fccf4ab78e61b656a68d5e077f0c0a1611989..5a02af6b47417161a8f6ae0c926e0d13084d9c94 100644
--- a/content/common/navigation_params.h
+++ b/content/common/navigation_params.h
@@ -140,6 +140,7 @@ struct CONTENT_EXPORT HistoryNavigationParams {
HistoryNavigationParams();
HistoryNavigationParams(const PageState& page_state,
int32 page_id,
+ int nav_entry_id,
int pending_history_list_offset,
int current_history_list_offset,
int current_history_list_length,
@@ -155,6 +156,11 @@ struct CONTENT_EXPORT HistoryNavigationParams {
// FrameHostMsg_DidCommitProvisionalLoad message.
int32 page_id;
Charlie Reis 2015/03/12 18:28:17 Maybe put a TODO(avi) to remove this in favor of n
Avi (use Gerrit) 2015/03/12 19:21:17 It feels weird to tag this one place that uses pag
+ // This is the unique id of the NavigationEntry being navigated to. If the
+ // load succeeds, then this nav_entry_id will be reflected in the resultant
+ // FrameHostMsg_DidCommitProvisionalLoad message.
+ int nav_entry_id;
+
// For history navigations, this is the offset in the history list of the
// pending load. For non-history navigations, this will be ignored.
int pending_history_list_offset;

Powered by Google App Engine
This is Rietveld 408576698