content/public/test/test_renderer_host.cc - Issue 1002803002: Classify navigations without page id in parallel to the existing classifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/test_renderer_host.cc

Issue 1002803002: Classify navigations without page id in parallel to the existing classifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: unit tests Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigator_impl_unittest.cc ('K') | « content/public/test/test_renderer_host.h ('k') | content/public/test/web_contents_tester.h » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/test_renderer_host.cc

diff --git a/content/public/test/test_renderer_host.cc b/content/public/test/test_renderer_host.cc

index fea075da9a30da9d62625ed629851df327e81d05..03e337416fe77b0ad57ebd97225dc6c8c54c6bcc 100644

--- a/content/public/test/test_renderer_host.cc

+++ b/content/public/test/test_renderer_host.cc

@@ -164,15 +164,16 @@ void RenderViewHostTestHarness::Reload() {

DCHECK(entry);

controller().Reload(false);

RenderFrameHostTester::For(main_rfh())->SendNavigateWithTransition(

- entry->GetPageID(), entry->GetURL(), ui::PAGE_TRANSITION_RELOAD);

+ entry->GetPageID(), entry->GetUniqueID(), false, entry->GetURL(),

+ ui::PAGE_TRANSITION_RELOAD);

}

void RenderViewHostTestHarness::FailedReload() {

NavigationEntry* entry = controller().GetLastCommittedEntry();

DCHECK(entry);

controller().Reload(false);

- RenderFrameHostTester::For(main_rfh())->SendFailedNavigate(entry->GetPageID(),

- entry->GetURL());

+ RenderFrameHostTester::For(main_rfh())->SendFailedNavigate(

+ entry->GetPageID(), entry->GetUniqueID(), false, entry->GetURL());

}

void RenderViewHostTestHarness::SetUp() {