content/public/renderer/navigation_state.cc - Issue 1002803002: Classify navigations without page id in parallel to the existing classifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/renderer/navigation_state.cc

Issue 1002803002: Classify navigations without page id in parallel to the existing classifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: unit tests Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigator_impl_unittest.cc ('K') | « content/public/renderer/navigation_state.h ('k') | content/public/test/render_view_test.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/renderer/navigation_state.cc

diff --git a/content/public/renderer/navigation_state.cc b/content/public/renderer/navigation_state.cc

index e5f91fa8186ee5080a49c9dcb897cceb2322c775..361a6daf5cb8309b2b230695f73fbd4f239f66fe 100644

--- a/content/public/renderer/navigation_state.cc

+++ b/content/public/renderer/navigation_state.cc

@@ -9,12 +9,14 @@ namespace content {

NavigationState::NavigationState(ui::PageTransition transition_type,

bool is_content_initiated,

int32 pending_page_id,

+ int pending_nav_entry_id,

int pending_history_list_offset,

bool history_list_was_cleared)

: transition_type_(transition_type),

request_committed_(false),

is_content_initiated_(is_content_initiated),

pending_page_id_(pending_page_id),

+ pending_nav_entry_id_(pending_nav_entry_id),

pending_history_list_offset_(pending_history_list_offset),

history_list_was_cleared_(history_list_was_cleared),

should_replace_current_entry_(false),