content/common/frame_messages.h - Issue 1002803002: Classify navigations without page id in parallel to the existing classifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/frame_messages.h

Issue 1002803002: Classify navigations without page id in parallel to the existing classifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: unit tests Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigator_impl_unittest.cc ('K') | « content/browser/web_contents/web_contents_impl_unittest.cc ('k') | content/common/navigation_params.h » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/frame_messages.h

diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h

index 38cd6baf033c0668cc77a0e587fdbcd611934b14..e3564ba8b0c0e5f5f89a28bd6cf1ac218e72b4ab 100644

--- a/content/common/frame_messages.h

+++ b/content/common/frame_messages.h

@@ -122,6 +122,7 @@ IPC_STRUCT_END()

IPC_STRUCT_TRAITS_BEGIN(content::FrameNavigateParams)

IPC_STRUCT_TRAITS_MEMBER(page_id)

+ IPC_STRUCT_TRAITS_MEMBER(nav_entry_id)

IPC_STRUCT_TRAITS_MEMBER(url)

IPC_STRUCT_TRAITS_MEMBER(base_url)

IPC_STRUCT_TRAITS_MEMBER(referrer)

@@ -140,6 +141,10 @@ IPC_STRUCT_BEGIN_WITH_PARENT(FrameHostMsg_DidCommitProvisionalLoad_Params,

content::FrameNavigateParams)

IPC_STRUCT_TRAITS_PARENT(content::FrameNavigateParams)

+ // Whether this commit created a new entry. TODO(avi): Does this need to go in

+ // FrameNavigateParams, instead?

+ IPC_STRUCT_MEMBER(bool, did_create_new_entry)

// Information regarding the security of the connection (empty if the

// connection was not secure).

IPC_STRUCT_MEMBER(std::string, security_info)

@@ -235,6 +240,7 @@ IPC_STRUCT_TRAITS_END()

IPC_STRUCT_TRAITS_BEGIN(content::HistoryNavigationParams)

IPC_STRUCT_TRAITS_MEMBER(page_state)

IPC_STRUCT_TRAITS_MEMBER(page_id)

+ IPC_STRUCT_TRAITS_MEMBER(nav_entry_id)

IPC_STRUCT_TRAITS_MEMBER(pending_history_list_offset)

IPC_STRUCT_TRAITS_MEMBER(current_history_list_offset)

IPC_STRUCT_TRAITS_MEMBER(current_history_list_length)