Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Side by Side Diff: content/common/navigation_params.h

Issue 1002803002: Classify navigations without page id in parallel to the existing classifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: relax the dcheck Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/common/frame_messages.h ('k') | content/common/navigation_params.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_COMMON_NAVIGATION_PARAMS_H_ 5 #ifndef CONTENT_COMMON_NAVIGATION_PARAMS_H_
6 #define CONTENT_COMMON_NAVIGATION_PARAMS_H_ 6 #define CONTENT_COMMON_NAVIGATION_PARAMS_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 // navigation that is ready to commit. 162 // navigation that is ready to commit.
163 struct CONTENT_EXPORT RequestNavigationParams { 163 struct CONTENT_EXPORT RequestNavigationParams {
164 RequestNavigationParams(); 164 RequestNavigationParams();
165 RequestNavigationParams(bool is_overriding_user_agent, 165 RequestNavigationParams(bool is_overriding_user_agent,
166 base::TimeTicks navigation_start, 166 base::TimeTicks navigation_start,
167 const std::vector<GURL>& redirects, 167 const std::vector<GURL>& redirects,
168 bool can_load_local_resources, 168 bool can_load_local_resources,
169 base::Time request_time, 169 base::Time request_time,
170 const PageState& page_state, 170 const PageState& page_state,
171 int32 page_id, 171 int32 page_id,
172 int nav_entry_id,
173 bool intended_as_new_entry,
172 int pending_history_list_offset, 174 int pending_history_list_offset,
173 int current_history_list_offset, 175 int current_history_list_offset,
174 int current_history_list_length, 176 int current_history_list_length,
175 bool should_clear_history_list); 177 bool should_clear_history_list);
176 ~RequestNavigationParams(); 178 ~RequestNavigationParams();
177 179
178 // Whether or not the user agent override string should be used. 180 // Whether or not the user agent override string should be used.
179 bool is_overriding_user_agent; 181 bool is_overriding_user_agent;
180 182
181 // The navigationStart time to expose through the Navigation Timing API to JS. 183 // The navigationStart time to expose through the Navigation Timing API to JS.
(...skipping 14 matching lines...) Expand all
196 198
197 // Opaque history state (received by ViewHostMsg_UpdateState). 199 // Opaque history state (received by ViewHostMsg_UpdateState).
198 PageState page_state; 200 PageState page_state;
199 201
200 // The page_id for this navigation, or -1 if it is a new navigation. Back, 202 // The page_id for this navigation, or -1 if it is a new navigation. Back,
201 // Forward, and Reload navigations should have a valid page_id. If the load 203 // Forward, and Reload navigations should have a valid page_id. If the load
202 // succeeds, then this page_id will be reflected in the resultant 204 // succeeds, then this page_id will be reflected in the resultant
203 // FrameHostMsg_DidCommitProvisionalLoad message. 205 // FrameHostMsg_DidCommitProvisionalLoad message.
204 int32 page_id; 206 int32 page_id;
205 207
208 // For browser-initiated navigations, this is the unique id of the
209 // NavigationEntry being navigated to. (For renderer-initiated navigations it
210 // is 0.) If the load succeeds, then this nav_entry_id will be reflected in
211 // the resulting FrameHostMsg_DidCommitProvisionalLoad message.
212 int nav_entry_id;
213
214 // For browser-initiated navigations, this is true if this is a new entry
215 // being navigated to. This is false otherwise. TODO(avi): Remove this when
216 // the pending entry situation is made sane and the browser keeps them around
217 // long enough to match them via nav_entry_id, above.
218 bool intended_as_new_entry;
219
206 // For history navigations, this is the offset in the history list of the 220 // For history navigations, this is the offset in the history list of the
207 // pending load. For non-history navigations, this will be ignored. 221 // pending load. For non-history navigations, this will be ignored.
208 int pending_history_list_offset; 222 int pending_history_list_offset;
209 223
210 // Where its current page contents reside in session history and the total 224 // Where its current page contents reside in session history and the total
211 // size of the session history list. 225 // size of the session history list.
212 int current_history_list_offset; 226 int current_history_list_offset;
213 int current_history_list_length; 227 int current_history_list_length;
214 228
215 // Whether session history should be cleared. In that case, the RenderView 229 // Whether session history should be cleared. In that case, the RenderView
(...skipping 11 matching lines...) Expand all
227 ~NavigationParams(); 241 ~NavigationParams();
228 242
229 CommonNavigationParams common_params; 243 CommonNavigationParams common_params;
230 StartNavigationParams start_params; 244 StartNavigationParams start_params;
231 RequestNavigationParams request_params; 245 RequestNavigationParams request_params;
232 }; 246 };
233 247
234 } // namespace content 248 } // namespace content
235 249
236 #endif // CONTENT_COMMON_NAVIGATION_PARAMS_H_ 250 #endif // CONTENT_COMMON_NAVIGATION_PARAMS_H_
OLDNEW
« no previous file with comments | « content/common/frame_messages.h ('k') | content/common/navigation_params.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698