Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: content/common/navigation_params.h

Issue 1002803002: Classify navigations without page id in parallel to the existing classifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: better crash url Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_COMMON_NAVIGATION_PARAMS_H_ 5 #ifndef CONTENT_COMMON_NAVIGATION_PARAMS_H_
6 #define CONTENT_COMMON_NAVIGATION_PARAMS_H_ 6 #define CONTENT_COMMON_NAVIGATION_PARAMS_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 // TODO(ppi): make it go away. 133 // TODO(ppi): make it go away.
134 base::Time request_time; 134 base::Time request_time;
135 }; 135 };
136 136
137 // Used by FrameMsg_Navigate. 137 // Used by FrameMsg_Navigate.
138 // PlzNavigate: sent to the renderer when the navigation is ready to commit. 138 // PlzNavigate: sent to the renderer when the navigation is ready to commit.
139 struct CONTENT_EXPORT HistoryNavigationParams { 139 struct CONTENT_EXPORT HistoryNavigationParams {
140 HistoryNavigationParams(); 140 HistoryNavigationParams();
141 HistoryNavigationParams(const PageState& page_state, 141 HistoryNavigationParams(const PageState& page_state,
142 int32 page_id, 142 int32 page_id,
143 int nav_entry_id,
143 int pending_history_list_offset, 144 int pending_history_list_offset,
144 int current_history_list_offset, 145 int current_history_list_offset,
145 int current_history_list_length, 146 int current_history_list_length,
146 bool should_clear_history_list); 147 bool should_clear_history_list);
147 ~HistoryNavigationParams(); 148 ~HistoryNavigationParams();
148 149
149 // Opaque history state (received by ViewHostMsg_UpdateState). 150 // Opaque history state (received by ViewHostMsg_UpdateState).
150 PageState page_state; 151 PageState page_state;
151 152
152 // The page_id for this navigation, or -1 if it is a new navigation. Back, 153 // The page_id for this navigation, or -1 if it is a new navigation. Back,
153 // Forward, and Reload navigations should have a valid page_id. If the load 154 // Forward, and Reload navigations should have a valid page_id. If the load
154 // succeeds, then this page_id will be reflected in the resultant 155 // succeeds, then this page_id will be reflected in the resultant
155 // FrameHostMsg_DidCommitProvisionalLoad message. 156 // FrameHostMsg_DidCommitProvisionalLoad message.
156 int32 page_id; 157 int32 page_id;
Charlie Reis 2015/03/12 18:28:17 Maybe put a TODO(avi) to remove this in favor of n
Avi (use Gerrit) 2015/03/12 19:21:17 It feels weird to tag this one place that uses pag
157 158
159 // This is the unique id of the NavigationEntry being navigated to. If the
160 // load succeeds, then this nav_entry_id will be reflected in the resultant
161 // FrameHostMsg_DidCommitProvisionalLoad message.
162 int nav_entry_id;
163
158 // For history navigations, this is the offset in the history list of the 164 // For history navigations, this is the offset in the history list of the
159 // pending load. For non-history navigations, this will be ignored. 165 // pending load. For non-history navigations, this will be ignored.
160 int pending_history_list_offset; 166 int pending_history_list_offset;
161 167
162 // Where its current page contents reside in session history and the total 168 // Where its current page contents reside in session history and the total
163 // size of the session history list. 169 // size of the session history list.
164 int current_history_list_offset; 170 int current_history_list_offset;
165 int current_history_list_length; 171 int current_history_list_length;
166 172
167 // Whether session history should be cleared. In that case, the RenderView 173 // Whether session history should be cleared. In that case, the RenderView
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 ~NavigationParams(); 220 ~NavigationParams();
215 221
216 CommonNavigationParams common_params; 222 CommonNavigationParams common_params;
217 StartNavigationParams start_params; 223 StartNavigationParams start_params;
218 CommitNavigationParams commit_params; 224 CommitNavigationParams commit_params;
219 HistoryNavigationParams history_params; 225 HistoryNavigationParams history_params;
220 }; 226 };
221 } // namespace content 227 } // namespace content
222 228
223 #endif // CONTENT_COMMON_NAVIGATION_PARAMS_H_ 229 #endif // CONTENT_COMMON_NAVIGATION_PARAMS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698