Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Issue 1002713002: [turbofan] Introduce builders for property access. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce builders for property access. This introduces a choke point in the AstGraphBuilder for property access creation. This makes it easier to enrich all such nodes with additional side-table or debugging information. R=titzer@chromium.org Committed: https://crrev.com/4dfff4abbd3a9513876c11b15aa27aacbb94fd3e Cr-Commit-Position: refs/heads/master@{#27157}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -52 lines) Patch
M src/compiler/ast-graph-builder.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 18 chunks +61 lines, -52 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 9 months ago (2015-03-12 12:06:40 UTC) #1
titzer
lgtm
5 years, 9 months ago (2015-03-12 13:36:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002713002/1
5 years, 9 months ago (2015-03-12 13:44:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-12 13:49:59 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 13:50:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4dfff4abbd3a9513876c11b15aa27aacbb94fd3e
Cr-Commit-Position: refs/heads/master@{#27157}

Powered by Google App Engine
This is Rietveld 408576698