Remove funky 2-stage initialization of ParserInfo and an adventurous memset.

src/parser.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_PARSER_H_
 #define V8_PARSER_H_
 
 #include "src/allocation.h"
 #include "src/ast.h"
 #include "src/compiler.h"  // TODO(titzer): remove this include dependency
 #include "src/pending-compilation-error-handler.h"
 #include "src/preparse-data.h"
 #include "src/preparse-data-format.h"
 #include "src/preparser.h"
 #include "src/scopes.h"
 
 namespace v8 {
 
 class ScriptCompiler;
 
 namespace internal {
 
 class Target;
 
 // A container for the inputs, configuration options, and outputs of parsing.
 class ParseInfo {
  public:
-  explicit ParseInfo(Zone* zone) {
-    memset(this, 0, sizeof(ParseInfo));
-    zone_ = zone;
-  }
+  // TODO(titzer) Make this private, see BackgroundParsingTask constructor.

[titzer, 2015/03/12 11:33:40]

So the solution to that would be a (Zone*,Isolate*) constructor, but I think I'd
rather discourage that and just leave this "naked" Zone constructor.

+  explicit ParseInfo(Zone* zone);
+
+  ParseInfo(Zone* zone, Handle<JSFunction> function);
+  ParseInfo(Zone* zone, Handle<SharedFunctionInfo> shared);
+  ParseInfo(Zone* zone, Handle<Script> script);
 
   ~ParseInfo() {
     if (ast_value_factory_owned()) {
       delete ast_value_factory_;
       set_ast_value_factory_owned(false);
     }
     ast_value_factory_ = nullptr;
   }
 
-  ParseInfo* InitializeFromJSFunction(Handle<JSFunction> function);
-  ParseInfo* InitializeFromSharedFunctionInfo(
-      Handle<SharedFunctionInfo> shared);
-  ParseInfo* InitializeFromScript(Handle<Script> script);
-
   Zone* zone() { return zone_; }
 
 // Convenience accessor methods for flags.
 #define FLAG_ACCESSOR(flag, getter, setter)     \
   bool getter() const { return GetFlag(flag); } \
   void setter() { SetFlag(flag); }              \
   void setter(bool val) { SetFlag(flag, val); }
 
   FLAG_ACCESSOR(kToplevel, is_toplevel, set_toplevel)
   FLAG_ACCESSOR(kLazy, is_lazy, set_lazy)
@@ skipping 1072 matching lines @@
 }
 
 
 Expression* ParserTraits::CloseTemplateLiteral(TemplateLiteralState* state,
                                                int start, Expression* tag) {
   return parser_->CloseTemplateLiteral(state, start, tag);
 }
 } }  // namespace v8::internal
 
 #endif  // V8_PARSER_H_