Remove funky 2-stage initialization of ParserInfo and an adventurous memset.

src/background-parsing-task.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/background-parsing-task.h"
 
 namespace v8 {
 namespace internal {
 
 BackgroundParsingTask::BackgroundParsingTask(
     StreamedSource* source, ScriptCompiler::CompileOptions options,
     int stack_size, Isolate* isolate)
     : source_(source), stack_size_(stack_size) {
   // We don't set the context to the CompilationInfo yet, because the background
   // thread cannot do anything with it anyway. We set it just before compilation
   // on the foreground thread.
   DCHECK(options == ScriptCompiler::kProduceParserCache ||
          options == ScriptCompiler::kProduceCodeCache ||
          options == ScriptCompiler::kNoCompileOptions);
 
   // Prepare the data for the internalization phase and compilation phase, which
   // will happen in the main thread after parsing.
   Zone* zone = new Zone();
+  // TODO(titzer) This looks like a missing constructor.
   ParseInfo* info = new ParseInfo(zone);
   source->zone.Reset(zone);
   source->info.Reset(info);
   info->set_isolate(isolate);
   info->set_source_stream(source->source_stream.get());
   info->set_source_stream_encoding(source->encoding);
   info->set_hash_seed(isolate->heap()->HashSeed());
   info->set_global();
   info->set_unicode_cache(&source_->unicode_cache);
 
@@ skipping 32 matching lines @@
   if (script_data != NULL) {
     source_->cached_data.Reset(new ScriptCompiler::CachedData(
         script_data->data(), script_data->length(),
         ScriptCompiler::CachedData::BufferOwned));
     script_data->ReleaseDataOwnership();
     delete script_data;
   }
 }
 }
 }  // namespace v8::internal