Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1002633005: Make navigator.permissions an instance of Permissions interface. (Closed)

Created:
5 years, 9 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 9 months ago
Reviewers:
whywhat, Mike West
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make navigator.permissions an instance of Permissions interface. This is exposing navigator.permissions instead of static methods on Permissions. Following TAG comments and various discussions. See spec bug: https://github.com/w3c/permissions/issues/11 BUG=437770 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192432

Patch Set 1 #

Patch Set 2 : update web exposed tests #

Patch Set 3 : update web exposed tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -18 lines) Patch
M LayoutTests/http/tests/permissions/resources/test-api-surface.js View 1 chunk +5 lines, -1 line 0 comments Download
M LayoutTests/http/tests/permissions/resources/test-query.js View 1 chunk +12 lines, -14 lines 0 comments Download
M LayoutTests/http/tests/permissions/test-api-surface.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/modules.gypi View 3 chunks +6 lines, -0 lines 0 comments Download
A Source/modules/permissions/NavigatorPermissions.h View 1 chunk +38 lines, -0 lines 0 comments Download
A Source/modules/permissions/NavigatorPermissions.cpp View 1 chunk +53 lines, -0 lines 0 comments Download
A Source/modules/permissions/NavigatorPermissions.idl View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M Source/modules/permissions/Permissions.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/permissions/Permissions.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/permissions/Permissions.idl View 1 chunk +1 line, -1 line 0 comments Download
A Source/modules/permissions/WorkerNavigatorPermissions.h View 1 chunk +38 lines, -0 lines 0 comments Download
A Source/modules/permissions/WorkerNavigatorPermissions.cpp View 1 chunk +53 lines, -0 lines 0 comments Download
A Source/modules/permissions/WorkerNavigatorPermissions.idl View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mlamouri (slow - plz ping)
5 years, 9 months ago (2015-03-23 21:41:44 UTC) #2
Mike West
LGTM. You'll need to update the webenabled/* test results, but those look like the only ...
5 years, 9 months ago (2015-03-24 04:48:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002633005/40001
5 years, 9 months ago (2015-03-24 12:20:44 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 13:46:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192432

Powered by Google App Engine
This is Rietveld 408576698