Raise SIGKILL if cast_service doesn't Finalize() within timeout.

chromecast/browser/cast_browser_main_parts.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/browser/cast_browser_main_parts.h"
 
+#if !defined(OS_ANDROID)
 #include <signal.h>
 #include <sys/prctl.h>
+#endif
 
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/path_service.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/run_loop.h"
 #include "cc/base/switches.h"
 #include "chromecast/base/metrics/cast_metrics_helper.h"
 #include "chromecast/base/metrics/grouped_histogram.h"
@@ skipping 55 matching lines @@
     if (sigaction(kSignalsToRunClosure[i], &sa_new, &sa_old) == -1) {
       NOTREACHED();
     } else {
       DCHECK_EQ(sa_old.sa_handler, SIG_DFL);
     }
   }
 
   // Get the first signal to exit when the parent process dies.
   prctl(PR_SET_PDEATHSIG, kSignalsToRunClosure[0]);
 }
+
+const int kKillOnAlarmTimeoutSec = 5;  // 5 seconds
+
+void KillOnAlarm(int signum) {
+  LOG(ERROR) << "Got alarm signal for termination: " << signum;
+  raise(SIGKILL);
+}
+
+void RegisterKillOnAlarm(int timeout_seconds) {
+  struct sigaction sa_new;
+  memset(&sa_new, 0, sizeof(sa_new));
+  sa_new.sa_handler = KillOnAlarm;
+  sigfillset(&sa_new.sa_mask);
+  sa_new.sa_flags = SA_RESTART;
+
+  struct sigaction sa_old;
+  if (sigaction(SIGALRM, &sa_new, &sa_old) == -1) {
+    NOTREACHED();
+  } else {
+    DCHECK_EQ(sa_old.sa_handler, SIG_DFL);
+  }
+
+  if (alarm(timeout_seconds) > 0) {
+    NOTREACHED() << "Previous alarm() was cancelled";
+  }

[byungchul, 2015/03/23 20:00:35]

remove {}

[maclellant, 2015/03/23 20:24:28]

Done.

+}
+
+void DeregisterKillOnAlarm() {
+  struct sigaction sa_new;
+  memset(&sa_new, 0, sizeof(sa_new));
+  sa_new.sa_handler = SIG_DFL;
+  sigfillset(&sa_new.sa_mask);
+  sa_new.sa_flags = SA_RESTART;
+
+  struct sigaction sa_old;
+  if (sigaction(SIGALRM, &sa_new, &sa_old) == -1) {
+    NOTREACHED();
+  } else {
+    DCHECK_EQ(sa_old.sa_handler, KillOnAlarm);
+  }
+}
 #endif  // !defined(OS_ANDROID)
 
 }  // namespace
 
 namespace chromecast {
 namespace shell {
 
 namespace {
 
 struct DefaultCommandLineSwitch {
@@ skipping 176 matching lines @@
   cast_browser_process_->cast_service()->Stop();
   return true;
 #endif
 }
 
 void CastBrowserMainParts::PostMainMessageLoopRun() {
 #if defined(OS_ANDROID)
   // Android does not use native main MessageLoop.
   NOTREACHED();
 #else
+  // If the services owned by the browser process do not finalize correctly, we
+  // trigger a SIGKILL on the current process to forcibly terminate. This avoids
+  // indefinte hangs when resources cannot clean up properly.
+  RegisterKillOnAlarm(kKillOnAlarmTimeoutSec);

[byungchul, 2015/03/23 20:00:35]

Should it be before cast_browser_process_->cast_service()->Stop() ?

[gunsch, 2015/03/23 20:14:21]

+1

[maclellant, 2015/03/23 20:24:28]

Done.

   cast_browser_process_->cast_service()->Finalize();
   cast_browser_process_->metrics_service_client()->Finalize();
   cast_browser_process_.reset();
+  DeregisterKillOnAlarm();
 #endif
 }
 
 }  // namespace shell
 }  // namespace chromecast