disable LCD for layers w/ filters

disable LCD for layers w/ filters

BUG=468311
see also skiabug.com/3567

Committed: https://skia.googlesource.com/skia/+/8dc0ccb8d33d1af7dd13228509e61fe915bc7705

[reed1, 2015-03-19 18:57:33]

reed@google.com changed reviewers:
+ robertphillips@google.com

[reed1, 2015-03-19 18:57:34]

ptal

[reed1, 2015-03-19 18:57:36]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-03-19 18:57:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1002603003/1

[commit-bot: I haz the power, 2015-03-19 18:57:48]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-03-20 00:57 UTC

[robertphillips, 2015-03-19 19:11:49]

https://codereview.chromium.org/1002603003/diff/1/gm/imagefiltersbase.cpp
File gm/imagefiltersbase.cpp (right):

https://codereview.chromium.org/1002603003/diff/1/gm/imagefiltersbase.cpp#new...
gm/imagefiltersbase.cpp:260: 
// This GM tests that LCD text is disabled when image filters are applied to a
saveLayer. ?

https://codereview.chromium.org/1002603003/diff/1/gm/imagefiltersbase.cpp#new...
gm/imagefiltersbase.cpp:265: protected:
override throughout ?
one line ?

https://codereview.chromium.org/1002603003/diff/1/gm/imagefiltersbase.cpp#new...
gm/imagefiltersbase.cpp:269: 
Does this GM need to be this large?

https://codereview.chromium.org/1002603003/diff/1/gm/imagefiltersbase.cpp#new...
gm/imagefiltersbase.cpp:283: canvas->translate(20, 40);
Wouldn't it be a more explicit test to actually perform a saveLayer here and
attach the paint to it ?

https://codereview.chromium.org/1002603003/diff/1/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/1002603003/diff/1/src/core/SkCanvas.cpp#newco...
src/core/SkCanvas.cpp:922: if (paint) {
test the color filter path too?

[reed1, 2015-03-19 20:07:36]

ptal

https://codereview.chromium.org/1002603003/diff/1/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/1002603003/diff/1/src/core/SkCanvas.cpp#newco...
src/core/SkCanvas.cpp:922: if (paint) {
On 2015/03/19 19:11:49, robertphillips wrote:
> test the color filter path too?

i.e. in the gm? good idea.

[reed1, 2015-03-19 20:07:39]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-03-19 20:07:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1002603003/20001

[commit-bot: I haz the power, 2015-03-19 20:07:50]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-03-20 02:07 UTC

[commit-bot: I haz the power, 2015-03-20 02:07:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-20 02:07:53]

No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer from
https://skia.googlesource.com/skia/+/master/CQ_COMMITTERS

[reed2, 2015-03-20 03:26:57]

reed@chromium.org changed reviewers:
+ reed@chromium.org

[reed2, 2015-03-20 03:26:57]

ptal

[robertphillips, 2015-03-20 12:30:17]

lgtm + ignoreable nits

https://codereview.chromium.org/1002603003/diff/20001/gm/imagefiltersbase.cpp
File gm/imagefiltersbase.cpp (right):

https://codereview.chromium.org/1002603003/diff/20001/gm/imagefiltersbase.cpp...
gm/imagefiltersbase.cpp:336: }
private:
    typedef ImageFiltersTextBaseGM INHERITED;
?

https://codereview.chromium.org/1002603003/diff/20001/gm/imagefiltersbase.cpp...
gm/imagefiltersbase.cpp:346: }
private:
    typedef ImageFiltersTextBaseGM INHERITED;
?

[reed1, 2015-03-20 13:13:12]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-03-20 13:13:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1002603003/20001

[commit-bot: I haz the power, 2015-03-20 13:32:55]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/8dc0ccb8d33d1af7dd13228509e61fe915bc7705