Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Side by Side Diff: remoting/webapp/unittests/apps_v2_migration_unittest.js

Issue 1002553002: Refactor sinon helper to make it easier to use. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * @suppress {checkTypes|checkVars|reportUnknownTypes|visibility} 7 * @suppress {checkTypes|checkVars|reportUnknownTypes|visibility}
8 */ 8 */
9 9
10 (function() { 10 (function() {
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 52
53 mockIsAppsV2.returns(false); 53 mockIsAppsV2.returns(false);
54 if (v1HasHosts) { 54 if (v1HasHosts) {
55 remoting.AppsV2Migration.saveUserInfo(); 55 remoting.AppsV2Migration.saveUserInfo();
56 } 56 }
57 } 57 }
58 58
59 module('AppsV2Migration', { 59 module('AppsV2Migration', {
60 setup: function() { 60 setup: function() {
61 chromeMocks.activate(['storage']); 61 chromeMocks.activate(['storage']);
62 mockIsAppsV2 = sinon.$setupStub(base, 'isAppsV2'); 62 mockIsAppsV2 = sinon.stub(base, 'isAppsV2');
63 remoting.identity = new remoting.Identity(); 63 remoting.identity = new remoting.Identity();
64 }, 64 },
65 teardown: function() { 65 teardown: function() {
66 chromeMocks.restore(); 66 chromeMocks.restore();
67 mockIsAppsV2.restore(); 67 mockIsAppsV2.restore();
68 remoting.identity = null; 68 remoting.identity = null;
69 } 69 }
70 }); 70 });
71 71
72 QUnit.asyncTest( 72 QUnit.asyncTest(
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 QUnit.asyncTest( 110 QUnit.asyncTest(
111 'saveUserInfo() should clear the preferences on v2', 111 'saveUserInfo() should clear the preferences on v2',
112 function() { 112 function() {
113 setMigrationData_('v1userName', 'v1user@gmail.com', true); 113 setMigrationData_('v1userName', 'v1user@gmail.com', true);
114 mockIsAppsV2.returns(true); 114 mockIsAppsV2.returns(true);
115 remoting.AppsV2Migration.saveUserInfo(); 115 remoting.AppsV2Migration.saveUserInfo();
116 remoting.AppsV2Migration.hasHostsInV1App().then(fail, pass); 116 remoting.AppsV2Migration.hasHostsInV1App().then(fail, pass);
117 }); 117 });
118 118
119 })(); 119 })();
OLDNEW
« no previous file with comments | « remoting/webapp/js_proto/sinon_stub_proto.js ('k') | remoting/webapp/unittests/base_unittest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698