Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1380)

Issue 1002553002: Refactor sinon helper to make it easier to use. (Closed)

Created:
5 years, 9 months ago by Sergey Ulanov
Modified:
5 years, 9 months ago
Reviewers:
garykac, kelvinp
CC:
chromium-reviews, jshin+watch_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor sinon helper to make it easier to use. Previously unittests using sinon were required to use sinon.$setupStub in order to typecheck correctly. It was usable only for the case when the test wants to stub a single method, but not when a whole object is stubbed. This CL gets rid of $setupStub and adds $testStub() function that simply casts parameter to the TestStub type. Committed: https://crrev.com/7ebfce1f9a43daef22f1d7601b4bbc031672bdc9 Cr-Commit-Position: refs/heads/master@{#320154}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -103 lines) Patch
M remoting/remoting_webapp_files.gypi View 1 2 chunks +0 lines, -2 lines 0 comments Download
M remoting/webapp/crd/html/template_unittest.html View 1 1 chunk +0 lines, -1 line 0 comments Download
D remoting/webapp/js_proto/sinon_stub_proto.js View 1 chunk +0 lines, -34 lines 0 comments Download
M remoting/webapp/unittests/apps_v2_migration_unittest.js View 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/unittests/base_unittest.js View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/webapp/unittests/host_table_entry_unittest.js View 5 chunks +7 lines, -7 lines 0 comments Download
M remoting/webapp/unittests/l10n_unittest.js View 7 chunks +14 lines, -11 lines 0 comments Download
M remoting/webapp/unittests/sinon_helpers.js View 1 1 chunk +4 lines, -14 lines 0 comments Download
D remoting/webapp/unittests/test_start.js View 1 1 chunk +0 lines, -12 lines 0 comments Download
M remoting/webapp/unittests/xmpp_connection_unittest.js View 5 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Sergey Ulanov
5 years, 9 months ago (2015-03-11 19:22:09 UTC) #2
garykac
lgtm
5 years, 9 months ago (2015-03-11 20:20:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002553002/60001
5 years, 9 months ago (2015-03-11 20:30:00 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 9 months ago (2015-03-11 21:51:43 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 21:52:18 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7ebfce1f9a43daef22f1d7601b4bbc031672bdc9
Cr-Commit-Position: refs/heads/master@{#320154}

Powered by Google App Engine
This is Rietveld 408576698