chromeos/process_proxy/process_output_watcher_unittest.cc - Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/process_proxy/process_output_watcher_unittest.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/process_proxy/process_output_watcher_unittest.cc

diff --git a/chromeos/process_proxy/process_output_watcher_unittest.cc b/chromeos/process_proxy/process_output_watcher_unittest.cc

index 9ff8d898e338cc92bf6964529a9c4b40f6fd3009..b45d137d36510d68ded601e0b362f79c84c8993e 100644

--- a/chromeos/process_proxy/process_output_watcher_unittest.cc

+++ b/chromeos/process_proxy/process_output_watcher_unittest.cc

@@ -127,8 +127,8 @@ public:

// Send stop signal. It is not important which string we send.

EXPECT_EQ(1, file_util::WriteFileDescriptor(stop_pipe[1], "q", 1));

- EXPECT_NE(-1, HANDLE_EINTR(close(stop_pipe[1])));

- EXPECT_NE(-1, HANDLE_EINTR(close(pt_pipe[1])));

+ EXPECT_NE(-1, IGNORE_EINTR(close(stop_pipe[1])));

+ EXPECT_NE(-1, IGNORE_EINTR(close(pt_pipe[1])));

output_watch_thread.Stop();

}