chrome/common/service_process_util_posix.cc - Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/service_process_util_posix.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/service_process_util_posix.cc

diff --git a/chrome/common/service_process_util_posix.cc b/chrome/common/service_process_util_posix.cc

index df57c912a621d29a81744b2ad52924580edf19b0..92b79b541053e3717c716db1590eb85865a1847a 100644

--- a/chrome/common/service_process_util_posix.cc

+++ b/chrome/common/service_process_util_posix.cc

@@ -133,12 +133,12 @@ void ServiceProcessState::StateData::SignalReady(base::WaitableEvent* signal,

ServiceProcessState::StateData::~StateData() {

if (sockets_[0] != -1) {

- if (HANDLE_EINTR(close(sockets_[0]))) {

+ if (IGNORE_EINTR(close(sockets_[0]))) {

DPLOG(ERROR) << "close";

}

if (sockets_[1] != -1) {

- if (HANDLE_EINTR(close(sockets_[1]))) {

+ if (IGNORE_EINTR(close(sockets_[1]))) {

DPLOG(ERROR) << "close";

}