base/message_loop/message_pump_libevent_unittest.cc - Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/message_loop/message_pump_libevent_unittest.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/message_loop/message_pump_libevent_unittest.cc

diff --git a/base/message_loop/message_pump_libevent_unittest.cc b/base/message_loop/message_pump_libevent_unittest.cc

index 52ca95bebf700ed4f547f409a018b56d8338859f..bf6d21c3280f52d05f7112bbbd48a94bd554122c 100644

--- a/base/message_loop/message_pump_libevent_unittest.cc

+++ b/base/message_loop/message_pump_libevent_unittest.cc

@@ -30,9 +30,9 @@ class MessagePumpLibeventTest : public testing::Test {

}

virtual void TearDown() OVERRIDE {

- if (HANDLE_EINTR(close(pipefds_[0])) < 0)

+ if (IGNORE_EINTR(close(pipefds_[0])) < 0)

PLOG(ERROR) << "close";

- if (HANDLE_EINTR(close(pipefds_[1])) < 0)

+ if (IGNORE_EINTR(close(pipefds_[1])) < 0)

PLOG(ERROR) << "close";

}