Convert tabs, windows, and extension APIs to feature system.

chrome/common/extensions/permission_feature.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/permission_feature.h"
 
 #include "chrome/common/extensions/extension_permission_set.h"
 
 namespace extensions {
 
 PermissionFeature::PermissionFeature() {
 }
 
 PermissionFeature::~PermissionFeature() {
 }
 
 Feature::Availability PermissionFeature::IsAvailableToContext(
     const Extension* extension,
     Feature::Context context,
     Feature::Platform platform) const {
   Availability availability = Feature::IsAvailableToContext(extension,
                                                             context,
                                                             platform);
   if (availability != IS_AVAILABLE)
     return availability;
 
-  if (!extension->HasAPIPermission(name()))
+  // TODO(aa): Lame to check optional permissions too (instead of just currently
+  // active permissions), but schema_generated_bindings.js calls this at
+  // bindings setup time, not call time. So it doesn't react properly to changes
+  // after the bindings are setup.
+  ExtensionAPIPermission* permission =
+      ExtensionPermissionsInfo::GetInstance()->GetByName(name());
+  if (!permission)
     return NOT_PRESENT;
 
+  if (!extension->required_permission_set()->HasAPIPermission(
+          permission->id()) &&
+      !extension->optional_permission_set()->HasAPIPermission(
+          permission->id())) {
+    return NOT_PRESENT;
+  }
+
   return IS_AVAILABLE;
 }
 
 }  // namespace