Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1002493003: Optimize parameters of list thumbnail loader for MTP volume. (Closed)

Created:
5 years, 9 months ago by yawano
Modified:
5 years, 9 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Optimize parameters of list thumbnail loader for MTP volume. On MTP volume, file operations are processed in the queue. If we enqueue a lot of thumbnail loading tasks, it can make the queue full and block other operations (e.g. directory read). In order not to block other operations, minimize the number of enqueued thumbnail loading on MTP volume. BUG=468623 TEST=out/Release/browser_tests --gtest_filter=FileManagerJsTest.ListThumbnailLoader Committed: https://crrev.com/81b8ccb5a93811db4738de9d8b6bfb2f03428591 Cr-Commit-Position: refs/heads/master@{#321315}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix annotations order. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -42 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 chunk +2 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js View 1 4 chunks +83 lines, -37 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.html View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.js View 5 chunks +26 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
yawano
PTAL. Thank you!
5 years, 9 months ago (2015-03-19 07:10:40 UTC) #2
hirono
lgtm! https://codereview.chromium.org/1002493003/diff/1/ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js File ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js (right): https://codereview.chromium.org/1002493003/diff/1/ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js#newcode114 ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js:114: * @return {number} Number of prefetch requests. nit: ...
5 years, 9 months ago (2015-03-19 07:53:04 UTC) #3
yawano
Thank you! https://codereview.chromium.org/1002493003/diff/1/ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js File ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js (right): https://codereview.chromium.org/1002493003/diff/1/ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js#newcode114 ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js:114: * @return {number} Number of prefetch requests. ...
5 years, 9 months ago (2015-03-19 07:57:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002493003/20001
5 years, 9 months ago (2015-03-19 07:58:13 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-19 08:24:38 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 08:25:17 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/81b8ccb5a93811db4738de9d8b6bfb2f03428591
Cr-Commit-Position: refs/heads/master@{#321315}

Powered by Google App Engine
This is Rietveld 408576698