Issue 1002453003: Make Stocks app search actually search

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1002453003: Make Stocks app search actually search (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
rafaelw

CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make Stocks app search actually search We don't yet reset the scroll offset, so sometimes you can't see your search results properly. R=rafaelw@chromium.org

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -19 lines)			Patch
M	sky/examples/stocks-fn/stocklist.dart	View	1 chunk	+10 lines, -8 lines	0 comments	Download
M	sky/examples/stocks-fn/stocksapp.dart	View	5 chunks	+17 lines, -4 lines	0 comments	Download
M	sky/framework/components/input.dart	View	2 chunks	+10 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 9 months ago (2015-03-11 19:07:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fa90272a72cb9930fe28d09465ef2227413b9f0c (presubmit successful).

Expand Messages | Collapse Messages