Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1002393005: Revert of ServiceWorker: Introduce SWMessageSender in order to mock IPC messaging (Closed)

Created:
5 years, 9 months ago by nhiroki
Modified:
5 years, 9 months ago
Reviewers:
Kunihiko Sakamoto
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch, michaeln
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ServiceWorker: Introduce SWMessageSender in order to mock IPC messaging (patchset #3 id:120001 of https://codereview.chromium.org/1011643002/) Reason for revert: Decided to take a different way to mock IPC messaging. See review comments on the original CL for more details. Original issue's description: > ServiceWorker: Introduce SWMessageSender in order to mock IPC messaging > > This CL introduces ServiceWorkerMessageSender that is a thin wrapper > of ThreadSafeSender so that unittests can inject a mock sender, and > adds some unittests related to reference counting using the mock. > > BUG=452403 > TEST=content_unittests --gtest_filter=ServiceWorkerDispatcherTest.* > > Committed: https://crrev.com/4d44fa9f7fb3d97b916781a6051ed4dcc69c3668 > Cr-Commit-Position: refs/heads/master@{#320885} TBR=ksakamoto@chromium.org BUG=452403 Committed: https://crrev.com/5279a9fe65fbb014a99c3f9d6fdc860a59b952cc Cr-Commit-Position: refs/heads/master@{#321080}

Patch Set 1 #

Patch Set 2 : fix patch apply failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -401 lines) Patch
M content/child/service_worker/service_worker_dispatcher.h View 1 6 chunks +8 lines, -9 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.cc View 1 12 chunks +27 lines, -19 lines 0 comments Download
D content/child/service_worker/service_worker_dispatcher_unittest.cc View 1 1 chunk +0 lines, -217 lines 0 comments Download
M content/child/service_worker/service_worker_handle_reference.h View 1 4 chunks +7 lines, -10 lines 0 comments Download
M content/child/service_worker/service_worker_handle_reference.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M content/child/service_worker/service_worker_message_filter.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M content/child/service_worker/service_worker_message_filter.cc View 1 8 chunks +18 lines, -14 lines 0 comments Download
D content/child/service_worker/service_worker_message_sender.h View 1 1 chunk +0 lines, -43 lines 0 comments Download
D content/child/service_worker/service_worker_message_sender.cc View 1 1 chunk +0 lines, -23 lines 0 comments Download
M content/child/service_worker/service_worker_provider_context.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/service_worker/service_worker_provider_context.cc View 1 5 chunks +16 lines, -14 lines 0 comments Download
M content/child/service_worker/service_worker_registration_handle_reference.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M content/child/service_worker/service_worker_registration_handle_reference.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M content/child/service_worker/web_service_worker_impl.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/child/service_worker/web_service_worker_impl.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M content/child/service_worker/web_service_worker_provider_impl.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M content/child/service_worker/web_service_worker_provider_impl.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M content/child/service_worker/web_service_worker_registration_impl.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M content/common/service_worker/service_worker_types.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/content_child.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/service_worker/embedded_worker_context_client.h View 1 3 chunks +2 lines, -3 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_context_client.cc View 1 5 chunks +5 lines, -6 lines 0 comments Download
M content/renderer/service_worker/service_worker_script_context.cc View 1 5 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
nhiroki
Created Revert of ServiceWorker: Introduce SWMessageSender in order to mock IPC messaging
5 years, 9 months ago (2015-03-18 02:21:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002393005/320001
5 years, 9 months ago (2015-03-18 04:09:55 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:320001)
5 years, 9 months ago (2015-03-18 05:34:13 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 05:35:03 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5279a9fe65fbb014a99c3f9d6fdc860a59b952cc
Cr-Commit-Position: refs/heads/master@{#321080}

Powered by Google App Engine
This is Rietveld 408576698