Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1002363002: Remove prerender cookie store, part 3. (Closed)

Created:
5 years, 9 months ago by davidben
Modified:
5 years, 9 months ago
Reviewers:
mmenke
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@prerender-revert-cookie-store-2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove prerender cookie store, part 3. This removes the plumbing in //content to pass a custom cookie store to a request. This reverts (a small portion of) https://codereview.chromium.org/188693003 BUG=457344 Committed: https://crrev.com/f71cc7bb28640f725daadfc9b3dc5b6ca92b68d3 Cr-Commit-Position: refs/heads/master@{#321624}

Patch Set 1 #

Patch Set 2 : also remove hook from ContentBrowserClient #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -64 lines) Patch
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 3 chunks +2 lines, -13 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 7 chunks +14 lines, -36 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
davidben
I'm giving you small easy CLs in preparation for the big scary one. ;-) (The ...
5 years, 9 months ago (2015-03-14 00:26:50 UTC) #2
mmenke
On 2015/03/14 00:26:50, David Benjamin wrote: > I'm giving you small easy CLs in preparation ...
5 years, 9 months ago (2015-03-20 13:39:51 UTC) #3
davidben
On 2015/03/20 13:39:51, mmenke wrote: > On 2015/03/14 00:26:50, David Benjamin wrote: > > I'm ...
5 years, 9 months ago (2015-03-20 17:34:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002363002/20001
5 years, 9 months ago (2015-03-20 18:15:57 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-20 20:35:11 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 20:35:56 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f71cc7bb28640f725daadfc9b3dc5b6ca92b68d3
Cr-Commit-Position: refs/heads/master@{#321624}

Powered by Google App Engine
This is Rietveld 408576698