Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1002353002: Add gn_unittests to linux bots. (Closed)

Created:
5 years, 9 months ago by tfarina
Modified:
5 years, 9 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, brettw, scottmg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add gn_unittests to linux bots. BUG=364645 TEST=trybots R=dpranke@chromium.org Committed: https://crrev.com/55116befde714e1af631ada42ed8f31f17f0ed12 Cr-Commit-Position: refs/heads/master@{#322111}

Patch Set 1 #

Patch Set 2 : use base's test launcher #

Patch Set 3 : gyp too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M testing/buildbot/chromium.linux.json View 4 chunks +4 lines, -0 lines 0 comments Download
M tools/gn/BUILD.gn View 1 2 chunks +1 line, -1 line 0 comments Download
M tools/gn/gn.gyp View 1 2 2 chunks +1 line, -1 line 0 comments Download
D tools/gn/run_all_unittests.cc View 1 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
tfarina
It looks green on linux_chromium_rel_gn -> http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/43375/steps/gn_unittests%20%28with%20patch%29/logs/stdio PTAL
5 years, 9 months ago (2015-03-14 00:28:54 UTC) #1
tfarina
To soon! Confused: 1 files were deleted from /tmp during the test run gn_unittests TEST ...
5 years, 9 months ago (2015-03-14 00:30:55 UTC) #2
brettw
This is because it doesn't use the test runner in base and instead just runs ...
5 years, 9 months ago (2015-03-14 05:05:47 UTC) #3
tfarina
Hey Brett, sorry for the delay. I was traveling. I'm back now. http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/45882 looks green ...
5 years, 9 months ago (2015-03-22 14:50:00 UTC) #4
brettw
lgtm
5 years, 9 months ago (2015-03-23 17:22:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002353002/40001
5 years, 9 months ago (2015-03-24 16:38:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/51598)
5 years, 9 months ago (2015-03-24 16:45:45 UTC) #10
Dirk Pranke
lgtm assuming it actually works (it's easy enough to revert if it doesn't).
5 years, 9 months ago (2015-03-25 01:29:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002353002/40001
5 years, 9 months ago (2015-03-25 01:39:42 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-25 03:40:30 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 03:41:17 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/55116befde714e1af631ada42ed8f31f17f0ed12
Cr-Commit-Position: refs/heads/master@{#322111}

Powered by Google App Engine
This is Rietveld 408576698