Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1002343003: [chromedriver] Disable broken/flaky network emulation tests (Closed)

Created:
5 years, 9 months ago by samuong
Modified:
5 years, 9 months ago
Reviewers:
stgao
CC:
chromium-reviews, samuong+watch_chromium.org, stgao, srawlins
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Disable broken/flaky network emulation tests We (srawlins@ and I) suspected that testEmulateNetworkConditionsSpeed would be flaky, but we wanted to try it on the buildbots first. Turns out we were right, and it is very flaky. It almost always fails on Android, and fails often on desktop too. So I'm deleting this test. BUG= Committed: https://crrev.com/41dfc8a6464890f6aca696c3c2075c930643e80f Cr-Commit-Position: refs/heads/master@{#320660}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -25 lines) Patch
M chrome/test/chromedriver/test/run_py_tests.py View 1 2 chunks +2 lines, -25 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
samuong
5 years, 9 months ago (2015-03-13 23:03:56 UTC) #2
stgao
lgtm https://codereview.chromium.org/1002343003/diff/1/chrome/test/chromedriver/test/run_py_tests.py File chrome/test/chromedriver/test/run_py_tests.py (right): https://codereview.chromium.org/1002343003/diff/1/chrome/test/chromedriver/test/run_py_tests.py#newcode159 chrome/test/chromedriver/test/run_py_tests.py:159: # WebView doesn't support emulating network conditions nit: ...
5 years, 9 months ago (2015-03-14 00:10:52 UTC) #3
samuong
https://codereview.chromium.org/1002343003/diff/1/chrome/test/chromedriver/test/run_py_tests.py File chrome/test/chromedriver/test/run_py_tests.py (right): https://codereview.chromium.org/1002343003/diff/1/chrome/test/chromedriver/test/run_py_tests.py#newcode159 chrome/test/chromedriver/test/run_py_tests.py:159: # WebView doesn't support emulating network conditions On 2015/03/14 ...
5 years, 9 months ago (2015-03-14 17:20:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002343003/20001
5 years, 9 months ago (2015-03-14 17:20:18 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-14 17:44:39 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-14 17:45:41 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/41dfc8a6464890f6aca696c3c2075c930643e80f
Cr-Commit-Position: refs/heads/master@{#320660}

Powered by Google App Engine
This is Rietveld 408576698