Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1002323002: Fixing memory error in ChromeWhispernetClientTest (Closed)

Created:
5 years, 9 months ago by Charlie
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang, rkc, DaleCurtis
CC:
chromium-reviews, rkc
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing memory error in ChromeWhispernetClientTest BUG=464843, 464120 Committed: https://crrev.com/623ae9a417a1fac3aaaf185f70e3ce5ad20f8fa5 Cr-Commit-Position: refs/heads/master@{#320645}

Patch Set 1 #

Patch Set 2 #

Patch Set 3 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M chrome/browser/copresence/chrome_whispernet_client_browsertest.cc View 1 2 2 chunks +20 lines, -8 lines 3 comments Download

Messages

Total messages: 12 (3 generated)
Charlie
5 years, 9 months ago (2015-03-13 22:35:38 UTC) #2
rkc
lgtm
5 years, 9 months ago (2015-03-13 22:48:24 UTC) #4
Lei Zhang
MSAN test run passed, so lgtm. https://codereview.chromium.org/1002323002/diff/40001/chrome/browser/copresence/chrome_whispernet_client_browsertest.cc File chrome/browser/copresence/chrome_whispernet_client_browsertest.cc (left): https://codereview.chromium.org/1002323002/diff/40001/chrome/browser/copresence/chrome_whispernet_client_browsertest.cc#oldcode238 chrome/browser/copresence/chrome_whispernet_client_browsertest.cc:238: (!defined(NDEBUG) && defined(OS_WIN)) ...
5 years, 9 months ago (2015-03-13 23:32:23 UTC) #5
Charlie
https://codereview.chromium.org/1002323002/diff/40001/chrome/browser/copresence/chrome_whispernet_client_browsertest.cc File chrome/browser/copresence/chrome_whispernet_client_browsertest.cc (left): https://codereview.chromium.org/1002323002/diff/40001/chrome/browser/copresence/chrome_whispernet_client_browsertest.cc#oldcode238 chrome/browser/copresence/chrome_whispernet_client_browsertest.cc:238: (!defined(NDEBUG) && defined(OS_WIN)) || \ On 2015/03/13 23:32:23, Lei ...
5 years, 9 months ago (2015-03-13 23:49:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002323002/40001
5 years, 9 months ago (2015-03-14 03:37:02 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-14 05:13:37 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/623ae9a417a1fac3aaaf185f70e3ce5ad20f8fa5 Cr-Commit-Position: refs/heads/master@{#320645}
5 years, 9 months ago (2015-03-14 05:14:06 UTC) #10
DaleCurtis
https://codereview.chromium.org/1002323002/diff/40001/chrome/browser/copresence/chrome_whispernet_client_browsertest.cc File chrome/browser/copresence/chrome_whispernet_client_browsertest.cc (right): https://codereview.chromium.org/1002323002/diff/40001/chrome/browser/copresence/chrome_whispernet_client_browsertest.cc#newcode217 chrome/browser/copresence/chrome_whispernet_client_browsertest.cc:217: for (int i = remaining_frames; i < dest->frames(); i++) ...
5 years, 9 months ago (2015-03-18 16:52:24 UTC) #11
chromium-reviews
5 years, 9 months ago (2015-03-18 17:42:47 UTC) #12
Message was sent while issue was closed. 
Sent you a CL.

On Wed, Mar 18, 2015 at 9:52 AM <dalecurtis@chromium.org> wrote:

>
> https://codereview.chromium.org/1002323002/diff/40001/
> chrome/browser/copresence/chrome_whispernet_client_browsertest.cc
> File chrome/browser/copresence/chrome_whispernet_client_browsertest.cc
> (right):
>
> https://codereview.chromium.org/1002323002/diff/40001/
> chrome/browser/copresence/chrome_whispernet_client_
> browsertest.cc#newcode217
> chrome/browser/copresence/chrome_whispernet_client_browsertest.cc:217
>
<https://codereview.chromium.org/1002323002/diff/40001/chrome/browser/copresen...>
> :
> for (int i = remaining_frames; i < dest->frames(); i++) {
> Should really be dest->ZeroPartialFrames() instead.
>
> https://codereview.chromium.org/1002323002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698