Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1300)

Unified Diff: Source/modules/presentation/PresentationSession.cpp

Issue 1002293005: [PresentationAPI] Plumbing send() from PresentationSession IDL to platform/. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/presentation/PresentationSession.cpp
diff --git a/Source/modules/presentation/PresentationSession.cpp b/Source/modules/presentation/PresentationSession.cpp
index 47ba6253b3d33c471419808f6e6918b48f272bdd..821f1b41b0c0ff326021f18edff0eadcf98b061b 100644
--- a/Source/modules/presentation/PresentationSession.cpp
+++ b/Source/modules/presentation/PresentationSession.cpp
@@ -5,7 +5,10 @@
#include "config.h"
#include "modules/presentation/PresentationSession.h"
+#include "core/dom/DOMArrayBuffer.h"
+#include "core/dom/DOMArrayBufferView.h"
#include "core/dom/Document.h"
+#include "core/dom/ExceptionCode.h"
#include "core/events/Event.h"
#include "core/frame/LocalFrame.h"
#include "modules/EventTargetModules.h"
@@ -36,6 +39,11 @@ const AtomicString& SessionStateToString(WebPresentationSessionState state)
return disconnectedValue;
}
+void throwInvalidStateError(ExceptionState& exceptionState)
whywhat 2015/03/26 00:14:19 Rename to something reflecting what kind of error
USE s.singapati at gmail.com 2015/03/26 11:57:40 Done.
+{
+ exceptionState.throwDOMException(InvalidStateError, "Presentation session is disconnected.");
+}
+
} // namespace
PresentationSession::PresentationSession(LocalFrame* frame, const String& id, const String& url)
@@ -90,7 +98,26 @@ const AtomicString& PresentationSession::state() const
return SessionStateToString(m_state);
}
-void PresentationSession::postMessage(const String& message)
+void PresentationSession::postMessage(const String& message, ExceptionState& exceptionState)
+{
+ if (m_state != WebPresentationSessionState::Connected) {
+ throwInvalidStateError(exceptionState);
+ return;
+ }
+ PresentationController* controller = presentationController();
+ if (controller)
+ controller->postMessage(m_url, m_id, message);
+}
+
+void PresentationSession::postMessage(Blob* data, ExceptionState& exceptionState)
+{
+}
+
+void PresentationSession::postMessage(DOMArrayBuffer* data, ExceptionState& exceptionState)
+{
Peter Beverloo 2015/03/25 20:20:29 Why is it OK for these methods to be empty? Can we
USE s.singapati at gmail.com 2015/03/26 11:57:40 Done. Added TODOs for now. I think blink side impl
+}
+
+void PresentationSession::postMessage(DOMArrayBufferView* data, ExceptionState& exceptionState)
{
}

Powered by Google App Engine
This is Rietveld 408576698