[PresentationAPI] Plumbing send() from PresentationSession IDL to platform/.

Source/modules/presentation/PresentationSession.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/presentation/PresentationSession.h"
 
+#include "core/dom/DOMArrayBuffer.h"
+#include "core/dom/DOMArrayBufferView.h"
 #include "core/dom/Document.h"
+#include "core/dom/ExceptionCode.h"
 #include "core/events/Event.h"
 #include "core/frame/LocalFrame.h"
 #include "modules/EventTargetModules.h"
 #include "modules/presentation/Presentation.h"
 #include "modules/presentation/PresentationController.h"
 #include "public/platform/modules/presentation/WebPresentationSessionClient.h"
 #include "wtf/Assertions.h"
 #include "wtf/OwnPtr.h"
 #include "wtf/text/AtomicString.h"
 
@@ skipping 10 matching lines @@
     case WebPresentationSessionState::Connected:
         return connectedValue;
     case WebPresentationSessionState::Disconnected:
         return disconnectedValue;
     }
 
     ASSERT_NOT_REACHED();
     return disconnectedValue;
 }
 
+void throwPresentationDisconnectedError(ExceptionState& exceptionState)
+{
+    exceptionState.throwDOMException(InvalidStateError, "Presentation session is disconnected.");
+}
+
 } // namespace
 
 PresentationSession::PresentationSession(LocalFrame* frame, const String& id, const String& url)
     : DOMWindowProperty(frame)
     , m_id(id)
     , m_url(url)
     , m_state(WebPresentationSessionState::Disconnected)
 {
 }
 
@@ skipping 34 matching lines @@
 {
     RefCountedGarbageCollectedEventTargetWithInlineData<PresentationSession>::trace(visitor);
     DOMWindowProperty::trace(visitor);
 }
 
 const AtomicString& PresentationSession::state() const
 {
     return SessionStateToString(m_state);
 }
 
-void PresentationSession::postMessage(const String& message)
+void PresentationSession::send(const String& message, ExceptionState& exceptionState)
 {
+    if (m_state != WebPresentationSessionState::Connected) {

[mlamouri (slow - plz ping), 2015/04/16 10:06:30]

In order to follow the specification, could you do == Disconnected instead?

[USE s.singapati at gmail.com, 2015/04/16 16:10:01]

Done.

+        throwPresentationDisconnectedError(exceptionState);
+        return;
+    }
+    if (message.isNull() || message.isEmpty())
+        return;

[mlamouri (slow - plz ping), 2015/04/16 10:06:30]

Why are you doing that check? If someone wants to send an empty string, why
should that be forbidden?

[USE s.singapati at gmail.com, 2015/04/16 16:10:02]

Done. What about byteLength() for ArrayBuffer/View?

[mlamouri (slow - plz ping), 2015/04/16 17:14:17]

Indeed.

[whywhat, 2015/04/16 17:29:44]

Because that's how WebRTC DataChannel works in Chromium? Its spec doesn't define
the behavior though.

+
+    PresentationController* controller = presentationController();
+    if (controller)
+        controller->send(m_url, m_id, message);
+}
+
+void PresentationSession::send(PassRefPtr<DOMArrayBuffer> data, ExceptionState& exceptionState)
+{
+    ASSERT(data && data->buffer());
+    sendInternal(static_cast<const char*>(data->data()), data->byteLength(), exceptionState);
+}
+
+void PresentationSession::send(PassRefPtr<DOMArrayBufferView> data, ExceptionState& exceptionState)
+{
+    ASSERT(data);
+    sendInternal(static_cast<const char*>(data->baseAddress()), data->byteLength(), exceptionState);
+}
+
+void PresentationSession::sendInternal(const char* data, size_t size, ExceptionState& exceptionState)
+{
+    ASSERT(data);
+    if (m_state != WebPresentationSessionState::Connected) {

[mlamouri (slow - plz ping), 2015/04/16 10:06:30]

ditto: use == Disconnected

[USE s.singapati at gmail.com, 2015/04/16 16:10:02]

Done.

+        throwPresentationDisconnectedError(exceptionState);
+        return;
+    }
+    if (!size)
+        return;
+
+    PresentationController* controller = presentationController();
+    if (controller)
+        controller->send(m_url, m_id, data, size);
 }
 
 void PresentationSession::close()
 {
     if (m_state != WebPresentationSessionState::Connected)
         return;
     PresentationController* controller = presentationController();
     if (controller)
         controller->closeSession(m_url, m_id);
 }
@@ skipping 13 matching lines @@
 }
 
 PresentationController* PresentationSession::presentationController()
 {
     if (!frame())
         return nullptr;
     return PresentationController::from(*frame());
 }
 
 } // namespace blink