Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1002293004: [Android] Make failure to find tombstones nonfatal. (Closed)

Created:
5 years, 9 months ago by jbudorick
Modified:
5 years, 9 months ago
Reviewers:
klundberg
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Make failure to find tombstones nonfatal. BUG=467918 Committed: https://crrev.com/724e0baba29a167e97c119335eff476fa4437269 Cr-Commit-Position: refs/heads/master@{#321219}

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressing Karin's offline comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -20 lines) Patch
M build/android/tombstones.py View 1 9 chunks +30 lines, -20 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
jbudorick
5 years, 9 months ago (2015-03-18 20:03:05 UTC) #2
jbudorick
https://codereview.chromium.org/1002293004/diff/1/build/android/tombstones.py File build/android/tombstones.py (right): https://codereview.chromium.org/1002293004/diff/1/build/android/tombstones.py#newcode51 build/android/tombstones.py:51: raise StopIteration This gets raised anyway, so I removed ...
5 years, 9 months ago (2015-03-18 21:04:51 UTC) #3
klundberg
lgtm
5 years, 9 months ago (2015-03-18 21:05:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002293004/20001
5 years, 9 months ago (2015-03-18 21:08:02 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-18 22:15:37 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/724e0baba29a167e97c119335eff476fa4437269 Cr-Commit-Position: refs/heads/master@{#321219}
5 years, 9 months ago (2015-03-18 22:16:14 UTC) #8
jbudorick
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1004803008/ by jbudorick@chromium.org. ...
5 years, 9 months ago (2015-03-19 01:12:18 UTC) #9
jbudorick
5 years, 9 months ago (2015-03-19 01:16:44 UTC) #10
Message was sent while issue was closed.
On 2015/03/19 01:12:18, jbudorick wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1004803008/ by mailto:jbudorick@chromium.org.
> 
> The reason for reverting is: Looks like this is causing flaky failures on the
> CQ..

Looks like this ran into a bug in python 2.7: http://bugs.python.org/issue7980

I'll have a revised CL up tomorrow.

Powered by Google App Engine
This is Rietveld 408576698