Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1002293002: DevTools: [SSP] refactor internal representations of sections (Closed)

Created:
5 years, 9 months ago by lushnikov
Modified:
5 years, 9 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, blink-reviews-style_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: [SSP] refactor internal representations of sections ATM styles sidebar pane holds a |sections| map which has pseudoIds as keys and arrays of StylePropertySections as values. This representation proved to be poor for our needs: we also want to have models for section separators. This patch purges |sections| map from SSP and introduces a |_sectionBlocks| array. Each element of the array is of a new type WI.SectionBlock, which is essentially an array of sections with a title element (the title element serves as a separator). BUG=466435 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191868

Patch Set 1 #

Patch Set 2 : kill commented out lines #

Total comments: 2

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -303 lines) Patch
M LayoutTests/http/tests/inspector-enabled/reattach-after-editing-styles-expected.txt View 3 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/inspector-enabled/shadow-dom-rules-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/inspector-enabled/shadow-dom-rules-restart-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/elements-test.js View 1 2 6 chunks +12 lines, -18 lines 0 comments Download
M LayoutTests/http/tests/inspector/elements/styles/edit-css-with-source-url-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/inspector/elements/styles/selector-line-deprecated-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/elements/styles/selector-line-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/elements/styles/selector-line-sourcemap-header-deprecated-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/elements/styles/selector-line-sourcemap-header-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/elements-delete-inline-style-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/elements-panel-styles-expected.txt View 3 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/inspector/elements/styles/add-new-rule-invalid-selector-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/add-new-rule-with-style-after-body-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/commit-selector-expected.txt View 3 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/inspector/elements/styles/commit-selector-mark-matching-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/css-live-edit-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/cssom-media-insert-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/disable-property-workingcopy-update-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/dynamic-style-tag-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/edit-inspector-stylesheet-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/edit-media-text-expected.txt View 3 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/inspector/elements/styles/edit-resource-referred-by-multiple-styletags-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/empty-background-url-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/force-pseudo-state-expected.txt View 3 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/inspector/elements/styles/inactive-properties-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/inherited-mixed-case-properties-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/inject-stylesheet-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/keyframes-rules-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/lazy-computed-style-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/media-emulation-expected.txt View 4 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/inspector/elements/styles/media-queries-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/media-using-same-url-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/parse-comments-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/parse-declaration-unterminated-comment-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/parse-declaration-with-quote-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/parse-utf8-bom-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/paste-property-expected.txt View 4 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/inspector/elements/styles/perform-undo-perform-of-mergable-action-expected.txt View 4 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/inspector/elements/styles/pseudo-elements-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/inspector/elements/styles/region-style-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/removed-rule-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/selector-list-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/shadow-dom-rules-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/style-rule-from-imported-stylesheet-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-add-blank-property-expected.txt View 4 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-add-invalid-property-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-add-new-rule-colon-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-add-new-rule-expected.txt View 4 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-add-new-rule-tab-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-add-new-rule-to-stylesheet-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/styles-cancel-editing-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-change-node-while-editing-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-commit-editing-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-computed-trace-expected.txt View 3 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-disable-inherited-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-disable-property-after-selector-edit.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/styles-disable-property-after-selector-edit-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/styles-disable-then-change-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-disable-then-delete-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-disable-then-enable-overriden-ua-expected.txt View 3 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-edit-property-after-invalid-rule-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-iframe-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-overriden-properties-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/styles-source-lines-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/styles-source-lines-inline-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/styles-source-lines-recovery-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/styles-update-from-js-expected.txt View 5 chunks +0 lines, -5 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-update-links.html View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-update-links-expected.txt View 6 chunks +0 lines, -7 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-with-spaces-in-sourceURL-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/svg-style-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/undo-add-new-rule-expected.txt View 3 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/inspector/elements/styles/undo-add-property-expected.txt View 12 chunks +0 lines, -12 lines 0 comments Download
M LayoutTests/inspector/elements/styles/undo-change-property-expected.txt View 4 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/inspector/elements/styles/undo-set-selector-text-expected.txt View 4 chunks +0 lines, -4 lines 0 comments Download
M Source/devtools/front_end/elements/StylesSidebarPane.js View 1 2 15 chunks +114 lines, -123 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
lushnikov
PTAL
5 years, 9 months ago (2015-03-13 17:16:45 UTC) #1
pfeldman
lgtm https://codereview.chromium.org/1002293002/diff/20001/Source/devtools/front_end/elements/StylesSidebarPane.js File Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/1002293002/diff/20001/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode1282 Source/devtools/front_end/elements/StylesSidebarPane.js:1282: appendSection: function(section) You encapsulate nothing. Lets remove these.
5 years, 9 months ago (2015-03-13 17:53:33 UTC) #2
lushnikov
https://codereview.chromium.org/1002293002/diff/20001/Source/devtools/front_end/elements/StylesSidebarPane.js File Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/1002293002/diff/20001/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode1282 Source/devtools/front_end/elements/StylesSidebarPane.js:1282: appendSection: function(section) On 2015/03/13 17:53:33, pfeldman wrote: > You ...
5 years, 9 months ago (2015-03-13 18:08:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002293002/40001
5 years, 9 months ago (2015-03-13 18:09:03 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 21:08:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191868

Powered by Google App Engine
This is Rietveld 408576698