Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issue 1002263006: Set a zero suggest impression for most visited. (Closed)

Created:
5 years, 9 months ago by Maria
Modified:
5 years, 9 months ago
Reviewers:
H Fung, Mark P
CC:
chromium-reviews, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set a zero suggest impression for most visited. Ensures that we can figure out how often zero suggest is triggered in a session. BUG= Committed: https://crrev.com/1535e6a957b41e0e5632ee050c04c86220620d1a Cr-Commit-Position: refs/heads/master@{#321531}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/autocomplete/zero_suggest_provider.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Maria
5 years, 9 months ago (2015-03-19 23:21:23 UTC) #2
H Fung
lgtm I'm not sure if you want to consider adding a separate histogram for mostvisited ...
5 years, 9 months ago (2015-03-19 23:38:26 UTC) #3
Maria
+ Mark for owners
5 years, 9 months ago (2015-03-20 00:39:38 UTC) #5
Mark P
lgtm
5 years, 9 months ago (2015-03-20 04:23:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002263006/1
5 years, 9 months ago (2015-03-20 06:16:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 07:48:59 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 07:49:47 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1535e6a957b41e0e5632ee050c04c86220620d1a
Cr-Commit-Position: refs/heads/master@{#321531}

Powered by Google App Engine
This is Rietveld 408576698