Beautify syntax error for unterminated argument list

Beautify syntax error for unterminated argument list

BUG=chromium:339474
LOG=Y

Committed: https://crrev.com/cb50b0dfe78d646097841c3de3ac70617755de6e
Cr-Commit-Position: refs/heads/master@{#27205}

[yurys, 2015-03-13 19:52:45]

Patchset #1 (id:1) has been deleted

[yurys, 2015-03-13 19:54:47]

yurys@chromium.org changed reviewers:
+ jochen@chromium.org, kozyatinskiy@chromium.org, yangguo@chromium.org

[yurys, 2015-03-13 19:54:48]

A couple of layout tests that currently expect 
"Uncaught SyntaxError: Unexpected end of input"
output will likely need to be updated before landing this change.

[Yang, 2015-03-16 07:24:33]

LGTM with suggestion.

https://codereview.chromium.org/1002263004/diff/20001/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/1002263004/diff/20001/src/preparser.h#newcode...
src/preparser.h:2320: done = (peek() == Token::RPAREN);
I think it's cleaner and easier to read if we check for Token::COMMA here to see
whether to continue looping, and...

https://codereview.chromium.org/1002263004/diff/20001/src/preparser.h#newcode...
src/preparser.h:2331: Expect(Token::RPAREN,
CHECK_OK_CUSTOM(NullExpressionList));
... check for Token::LPAREN here, throwing unterminated_arg_list if it's not.

That way the error message corresponds to the expectation.

[yurys, 2015-03-16 08:56:23]

https://codereview.chromium.org/1002263004/diff/20001/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/1002263004/diff/20001/src/preparser.h#newcode...
src/preparser.h:2320: done = (peek() == Token::RPAREN);
On 2015/03/16 07:24:33, Yang wrote:
> I think it's cleaner and easier to read if we check for Token::COMMA here to
see
> whether to continue looping, and...

Done.

https://codereview.chromium.org/1002263004/diff/20001/src/preparser.h#newcode...
src/preparser.h:2331: Expect(Token::RPAREN,
CHECK_OK_CUSTOM(NullExpressionList));
On 2015/03/16 07:24:33, Yang wrote:
> ... check for Token::LPAREN here, throwing unterminated_arg_list if it's not.
> 
> That way the error message corresponds to the expectation.

Done.

[yurys, 2015-03-16 08:56:37]

The CQ bit was checked by yurys@chromium.org

[yurys, 2015-03-16 08:56:37]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1002263004/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-03-16 08:56:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1002263004/60001

[commit-bot: I haz the power, 2015-03-16 09:16:21]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-03-16 09:16:34]

Patchset 3 (id:??) landed as
https://crrev.com/cb50b0dfe78d646097841c3de3ac70617755de6e
Cr-Commit-Position: refs/heads/master@{#27205}