Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: test/mjsunit/strong/classes.js

Issue 1002253002: [strong] Check super constructor calls (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Typo Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/messages.js ('K') | « test/cctest/test-parsing.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/strong/classes.js
diff --git a/test/mjsunit/strong/classes.js b/test/mjsunit/strong/classes.js
index 3c7caf5f84e4a5d31ac3519d975816a4be05ae8b..716fc0ff8ebfc83b0dc73ce1428ba1827344fad4 100644
--- a/test/mjsunit/strong/classes.js
+++ b/test/mjsunit/strong/classes.js
@@ -3,6 +3,7 @@
// found in the LICENSE file.
// Flags: --strong-mode
+// Flags: --harmony-classes --harmony-arrow-functions
'use strong';
@@ -15,3 +16,36 @@ class C {}
assertEquals('function', typeof C);
assertEquals('function', typeof D);
})();
+
+function constructor(body) {
+ return "'use strong'; " +
+ "(class extends Object { constructor() { " + body + " } })";
+}
+
+(function NoMissingSuper() {
+ let bodies = [
+ "",
+ "1;"
+ ];
+ for (let b of bodies) assertThrows(constructor(b), SyntaxError);
marja 2015/03/13 15:21:20 Nit: this style of writing tests will give less us
+})();
+
+(function NoNestedSuper() {
+ let bodies = [
+ "(super())",
+ "(() => super())(); } })",
+ "{ super();",
+ "if (1) super();",
+ ];
+ for (let b of bodies) assertThrows(constructor(b), SyntaxError);
+})();
+
+(function NoDuplicateSuper() {
+ let bodies = [
+ "super(), super();",
+ "super(); super();",
+ "super(); (super());",
+ "super(); { super() }",
+ ];
+ for (let b of bodies) assertThrows(constructor(b), SyntaxError);
+})();
« src/messages.js ('K') | « test/cctest/test-parsing.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698