Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1002193005: Properly determine if a new key was added in AesDecryptor::Update() (Closed)

Created:
5 years, 9 months ago by jrummell
Modified:
5 years, 9 months ago
CC:
chromium-reviews, eme-reviews_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Properly determine if a new key was added in AesDecryptor::Update() BUG=448219 TEST=new test passes Committed: https://crrev.com/4d83add3219d80f900912f5f5d260f54a7952af1 Cr-Commit-Position: refs/heads/master@{#320958}

Patch Set 1 #

Patch Set 2 : Fix pipeline test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -47 lines) Patch
M media/cdm/aes_decryptor.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/cdm/aes_decryptor.cc View 4 chunks +18 lines, -3 lines 0 comments Download
M media/cdm/aes_decryptor_unittest.cc View 26 chunks +67 lines, -44 lines 0 comments Download
M media/test/pipeline_integration_test.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
jrummell
PTAL
5 years, 9 months ago (2015-03-14 00:50:17 UTC) #2
sandersd (OOO until July 31)
lgtm
5 years, 9 months ago (2015-03-16 20:07:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002193005/1
5 years, 9 months ago (2015-03-17 01:27:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/43990)
5 years, 9 months ago (2015-03-17 05:59:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002193005/20001
5 years, 9 months ago (2015-03-17 18:16:45 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-17 19:43:37 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 19:44:34 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4d83add3219d80f900912f5f5d260f54a7952af1
Cr-Commit-Position: refs/heads/master@{#320958}

Powered by Google App Engine
This is Rietveld 408576698