Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 1002193002: Experimental: remove duplicate script scope. (Closed)

Created:
5 years, 9 months ago by marja
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove duplicate script scope. We previously had two nested SCRIPT_SCOPEs (used to be GLOBAL_SCOPES), but as the lexical variable implementation changed, the inner one is no longer needed. BUG= Committed: https://crrev.com/0c56d7e8092e130cb1c6c11cfa18dc968f74d131 Cr-Commit-Position: refs/heads/master@{#27176}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/parser.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Dmitry Lomov (no reviews)
lgtm if tests pass
5 years, 9 months ago (2015-03-13 09:33:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002193002/1
5 years, 9 months ago (2015-03-13 09:43:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-13 09:46:11 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 09:46:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c56d7e8092e130cb1c6c11cfa18dc968f74d131
Cr-Commit-Position: refs/heads/master@{#27176}

Powered by Google App Engine
This is Rietveld 408576698