Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Issue 100213012: [NaCl SDK] Add NetworkMonitor example. (Closed)

Created:
7 years ago by binji
Modified:
7 years ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, binji, Sam Clegg
Visibility:
Public.

Description

[NaCl SDK] Add NetworkMonitor example. BUG=none R=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241723

Patch Set 1 #

Total comments: 8

Patch Set 2 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+279 lines, -5 lines) Patch
M native_client_sdk/src/build_tools/sdk_files.list View 1 chunk +1 line, -0 lines 0 comments Download
A + native_client_sdk/src/examples/api/network_monitor/example.dsc View 2 chunks +6 lines, -5 lines 0 comments Download
A native_client_sdk/src/examples/api/network_monitor/example.js View 1 1 chunk +57 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/api/network_monitor/index.html View 1 chunk +60 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/api/network_monitor/network_monitor.cc View 1 1 chunk +155 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
binji
7 years ago (2013-12-17 23:37:03 UTC) #1
Sam Clegg
lgtm https://codereview.chromium.org/100213012/diff/1/native_client_sdk/src/examples/api/network_monitor/network_monitor.cc File native_client_sdk/src/examples/api/network_monitor/network_monitor.cc (right): https://codereview.chromium.org/100213012/diff/1/native_client_sdk/src/examples/api/network_monitor/network_monitor.cc#newcode53 native_client_sdk/src/examples/api/network_monitor/network_monitor.cc:53: if (result < PP_OK_COMPLETIONPENDING) { Why not != ...
7 years ago (2013-12-18 00:17:56 UTC) #2
binji
https://codereview.chromium.org/100213012/diff/1/native_client_sdk/src/examples/api/network_monitor/network_monitor.cc File native_client_sdk/src/examples/api/network_monitor/network_monitor.cc (right): https://codereview.chromium.org/100213012/diff/1/native_client_sdk/src/examples/api/network_monitor/network_monitor.cc#newcode53 native_client_sdk/src/examples/api/network_monitor/network_monitor.cc:53: if (result < PP_OK_COMPLETIONPENDING) { On 2013/12/18 00:17:56, Sam ...
7 years ago (2013-12-18 01:11:41 UTC) #3
Sam Clegg
slgtm
7 years ago (2013-12-18 17:29:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/100213012/20001
7 years ago (2013-12-18 21:42:11 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-19 00:34:18 UTC) #6
Message was sent while issue was closed.
Change committed as 241723

Powered by Google App Engine
This is Rietveld 408576698