Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 100213009: Stop building Chrome Frame tests. (Closed)

Created:
7 years ago by grt (UTC plus 2)
Modified:
6 years, 11 months ago
Reviewers:
csharp, jam, M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Stop building Chrome Frame tests. They are no longer run on any bots, so save time by not building them. BUG=316496 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242796

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase to r242769 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -43 lines) Patch
M build/all.gyp View 1 5 chunks +3 lines, -33 lines 0 comments Download
M chrome/chrome.gyp View 1 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
grt (UTC plus 2)
Can either of you think of any other configuration that needs to be adjusted for ...
7 years ago (2013-12-17 20:28:53 UTC) #1
M-A Ruel
Before committing this, the chrome_frame steps must have been removed from the masters and the ...
7 years ago (2013-12-17 20:43:49 UTC) #2
grt (UTC plus 2)
On 2013/12/17 20:43:49, M-A Ruel wrote: > Before committing this, the chrome_frame steps must have ...
7 years ago (2013-12-18 04:10:36 UTC) #3
grt (UTC plus 2)
https://codereview.chromium.org/100213009/diff/1/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/100213009/diff/1/build/all.gyp#newcode156 build/all.gyp:156: # TODO(jschuh) Enable Win64 Chrome Frame. crbug.com/176875 On 2013/12/17 ...
7 years ago (2013-12-18 04:10:48 UTC) #4
grt (UTC plus 2)
The buildbot config changes have landed. PTAL.
7 years ago (2013-12-23 18:45:17 UTC) #5
M-A Ruel
lgtm
7 years ago (2013-12-23 19:04:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/100213009/1
7 years ago (2013-12-23 20:52:37 UTC) #7
grt (UTC plus 2)
+jam for chrome/chrome.gyp OWNERS review.
7 years ago (2013-12-23 21:05:42 UTC) #8
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=42671
7 years ago (2013-12-23 21:12:13 UTC) #9
jam
On 2013/12/23 21:05:42, grt wrote: > +jam for chrome/chrome.gyp OWNERS review. rubberstamp lgtm. feel free ...
7 years ago (2013-12-24 00:09:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/100213009/170001
6 years, 11 months ago (2014-01-02 15:20:58 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=240967
6 years, 11 months ago (2014-01-02 20:01:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/100213009/170001
6 years, 11 months ago (2014-01-02 20:30:32 UTC) #13
commit-bot: I haz the power
6 years, 11 months ago (2014-01-02 21:13:44 UTC) #14
Message was sent while issue was closed.
Change committed as 242796

Powered by Google App Engine
This is Rietveld 408576698