Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: sky/tools/shelldb

Issue 1002123003: Add a --no_install option to shelldb (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/shelldb
diff --git a/sky/tools/shelldb b/sky/tools/shelldb
index 59513217ab4612a0cfcf9c0a1deded58f78bfdfa..ba5b1d1bd95a63849018719d9100a7f5e5c596c8 100755
--- a/sky/tools/shelldb
+++ b/sky/tools/shelldb
@@ -113,6 +113,9 @@ class StartSky(object):
start_parser.add_argument('build_dir', type=str)
start_parser.add_argument('url_or_path', nargs='?', type=str,
default=DEFAULT_URL)
+ start_parser.add_argument('--no_install', action="store_false",
+ default=True, dest="install",
+ help="Don't install SkyDemo.apk before starting")
start_parser.set_defaults(func=self.run)
def _server_root_for_url(self, url_or_path):
@@ -159,7 +162,8 @@ class StartSky(object):
pids['build_dir'] = os.path.abspath(args.build_dir)
- subprocess.check_call([ADB_PATH, 'install', '-r', apk_path])
+ if args.install:
+ subprocess.check_call([ADB_PATH, 'install', '-r', apk_path])
port_string = 'tcp:%s' % sky_server.port
subprocess.check_call([
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698