Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Issue 1002043002: Revert of Add MarkAlternativeServiceRecentlyBroken. (Closed)

Created:
5 years, 9 months ago by Bence
Modified:
5 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add MarkAlternativeServiceRecentlyBroken. (patchset #2 id:60001 of https://codereview.chromium.org/989273005/) Reason for revert: Reverting so that https://codereview.chromium.org/997953003/ can be reverted. BUG=466706 Original issue's description: > Add MarkAlternativeServiceRecentlyBroken. > > Add HttpServiceProperties::MarkAlternativeServiceRecentlyBroken() and its > unittests. Call it in QuicStreamFactory::ProcessGoingAwaySession. > > BUG=392576 > > Committed: https://crrev.com/35470e76130167053b49c81da373e056ce60b184 > Cr-Commit-Position: refs/heads/master@{#320315} TBR=rch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=392576 Committed: https://crrev.com/05c344cf5bcdaf5d11127729542c2d473006b497 Cr-Commit-Position: refs/heads/master@{#320327}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -46 lines) Patch
M net/http/http_server_properties.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/http/http_server_properties_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M net/http/http_server_properties_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/http/http_server_properties_manager.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 chunk +22 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bence
Created Revert of Add MarkAlternativeServiceRecentlyBroken.
5 years, 9 months ago (2015-03-12 18:30:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002043002/1
5 years, 9 months ago (2015-03-12 18:31:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-12 18:32:51 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 18:33:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05c344cf5bcdaf5d11127729542c2d473006b497
Cr-Commit-Position: refs/heads/master@{#320327}

Powered by Google App Engine
This is Rietveld 408576698