Issue 1002013010: Change include order in logging_unittest.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1002013010: Change include order in logging_unittest.cc (Closed)

Created:
5 years, 9 months ago by tommi (sloooow) - chröme

Modified:
5 years, 9 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Change include order in logging_unittest.cc to not override Chromium logging macros in Chromium headers. BUG=468375 TBR=zea@chromium.org Committed: https://crrev.com/d7c94e2d2e8e49f439e805e8f210822824f85cbd Cr-Commit-Position: refs/heads/master@{#321546}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	jingle/glue/logging_unittest.cc	View		1 chunk	+7 lines, -5 lines	0 comments	Download

Total messages: 7 (2 generated)

tommi (sloooow) - chröme

TBR-ing since this is causing build issues on try bots (see bug)

5 years, 9 months ago (2015-03-20 10:52:53 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002013010/1

5 years, 9 months ago (2015-03-20 10:53:04 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-20 10:58:01 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d7c94e2d2e8e49f439e805e8f210822824f85cbd
Cr-Commit-Position: refs/heads/master@{#321546}