Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 1002013009: Extract key metadata from the client certificate on Windows. (Closed)

Created:
5 years, 9 months ago by davidben
Modified:
5 years, 9 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract key metadata from the client certificate on Windows. Querying CAPI and CNG seem to both fail on some environments. Rather than hope smartcards and whatnot implement the necessary features, bypass Windows APIs entirely and extract the information out of the public key in the certificate using BoringSSL APIs. BUG=468345 Committed: https://crrev.com/c60e333c3f3f8e00fb14aff60434de2b79a28157 Cr-Commit-Position: refs/heads/master@{#321287}

Patch Set 1 #

Patch Set 2 : less churn #

Total comments: 2

Patch Set 3 : unnecessary include (already in the header) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -116 lines) Patch
M net/ssl/openssl_platform_key_win.cc View 1 2 11 chunks +38 lines, -116 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
https://codereview.chromium.org/1002013009/diff/20001/net/ssl/openssl_platform_key_win.cc File net/ssl/openssl_platform_key_win.cc (left): https://codereview.chromium.org/1002013009/diff/20001/net/ssl/openssl_platform_key_win.cc#oldcode452 net/ssl/openssl_platform_key_win.cc:452: if (degree == 0) { I'm not sure why ...
5 years, 9 months ago (2015-03-18 21:42:32 UTC) #2
Ryan Sleevi
lgtm
5 years, 9 months ago (2015-03-19 03:20:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002013009/40001
5 years, 9 months ago (2015-03-19 04:01:54 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-19 04:05:24 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 04:05:51 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c60e333c3f3f8e00fb14aff60434de2b79a28157
Cr-Commit-Position: refs/heads/master@{#321287}

Powered by Google App Engine
This is Rietveld 408576698