Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: chrome/browser/ssl/ssl_blocking_page.cc

Issue 1002013008: Launch date+time settings on BrowserThread::FILE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_blocking_page.cc
diff --git a/chrome/browser/ssl/ssl_blocking_page.cc b/chrome/browser/ssl/ssl_blocking_page.cc
index a56fa7d6018c75d25a072fbc0ecb15785d83af01..64079cf8e9388f462563aae9bccfe57f85717180 100644
--- a/chrome/browser/ssl/ssl_blocking_page.cc
+++ b/chrome/browser/ssl/ssl_blocking_page.cc
@@ -28,6 +28,7 @@
#include "chrome/grit/chromium_strings.h"
#include "chrome/grit/generated_resources.h"
#include "components/google/core/browser/google_util.h"
+#include "content/public/browser/browser_thread.h"
#include "content/public/browser/cert_store.h"
#include "content/public/browser/interstitial_page.h"
#include "content/public/browser/interstitial_page_delegate.h"
@@ -119,6 +120,7 @@ void RecordSSLExpirationPageEventState(bool expired_but_previously_allowed,
}
void LaunchDateAndTimeSettings() {
+ DCHECK_CURRENTLY_ON(content::BrowserThread::FILE);
// The code for each OS is completely separate, in order to avoid bugs like
// https://crbug.com/430877 .
#if defined(OS_ANDROID)
@@ -492,7 +494,8 @@ void SSLBlockingPage::CommandReceived(const std::string& command) {
case CMD_OPEN_DATE_SETTINGS: {
metrics_helper_->RecordUserInteraction(
SecurityInterstitialMetricsHelper::OPEN_TIME_SETTINGS);
- LaunchDateAndTimeSettings();
+ content::BrowserThread::PostTask(content::BrowserThread::FILE, FROM_HERE,
+ base::Bind(&LaunchDateAndTimeSettings));
break;
}
case CMD_OPEN_DIAGNOSTIC:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698