android_webview/browser/test/fake_window.cc - Issue 1002013003: Unit Test for WebView animating in and out of screen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/test/fake_window.cc

Issue 1002013003: Unit Test for WebView animating in and out of screen (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/browser_view_renderer_unittest.cc ('K') | « android_webview/browser/test/fake_window.h ('k') | android_webview/browser/test/rendering_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/test/fake_window.cc

diff --git a/android_webview/browser/test/fake_window.cc b/android_webview/browser/test/fake_window.cc

index 0a0956bab3a5316b7ea9e169edfae55ee7bdfad1..ccd0a7760130b1393ce5d1dbab11fbf510f01dbd 100644

--- a/android_webview/browser/test/fake_window.cc

+++ b/android_webview/browser/test/fake_window.cc

@@ -119,8 +119,8 @@ void FakeWindow::OnDrawHardware() {

DCHECK(on_draw_hardware_pending_);

on_draw_hardware_pending_ = false;

- hooks_->WillOnDraw();

view_->PrepareToDraw(gfx::Vector2d(), location_);

+ hooks_->WillOnDraw();

bool success = view_->OnDrawHardware();

hooks_->DidOnDraw(success);

if (success) {

@@ -180,7 +180,9 @@ void FakeWindow::DrawFunctorOnRT(base::WaitableEvent* sync) {

draw_info.transform[14] = 0.0;

draw_info.transform[15] = 1.0;

- hooks_->WillDrawOnRT(functor_);

+ if (!hooks_->WillDrawOnRT(functor_))

+ return;

{

ScopedMakeCurrent make_current(this);

functor_->DrawGL(&draw_info);